Try pt-pt image fix #201
Merged
Try pt-pt image fix #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It worked! @huey735 |
|
Just to be sure, does this mean that for the future we need to rename the image files and the urls inside dao_content_tr.yml? |
|
Yes, each image for each language needs to have a filename that's different from that of the same image in every other language (e.g., just append the image file with the language code). To be honest, I'm not sure it's worth the effort. Feel free to change them all back English if you like. I don't think it's a big deal. The images are meant to be visual anyway, so I'm sure people could get the main idea from the illustrations. But that's the way to make it functional, if you'd like to stick with it. |
This was referenced Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard to test locally, as images work fine locally, and I don't have access to Netlify. Will revert this pull request if it doesn't work.