Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The website is using the wrong images in the pt-PT DAO page #196

Closed
huey735 opened this issue Jul 19, 2019 · 2 comments
Closed

The website is using the wrong images in the pt-PT DAO page #196

huey735 opened this issue Jul 19, 2019 · 2 comments

Comments

@huey735
Copy link
Contributor

huey735 commented Jul 19, 2019

For some reason that is beyond my understanding of Jekyll, the website served by Github is using the wrong images.

There is:
~/images/DAO/

  • dao_benefits.svg
  • dao_how.svg
  • dao_intro.svg
  • dao_what.svg
  • dao_why.svg
    and
    ~/pt-PT/images/DAO/
  • dao_benefits.svg
  • dao_how.svg
  • dao_intro.svg
  • dao_what.svg
  • dao_why.svg

These folders contain the images rendered in bisq.network/dao and bisq.network/pt-pt/dao. I decided not to change the names of the .svg files because they're in different folders and that way we don't have to change any Liquid tags around the website.

These files are being requested by
pt-PT file ~/_data/dao_content_tr.yml which in in turn is being requested by ~/pt-PT/dao.html

If you clone the repository and run it locally, Jekyll uses the correct images for the pt-PT version of the DAO page.

@erciccione @m52go @ripcurlx

@huey735 huey735 changed the title The website is using the wrong images in the DAO page The website is using the wrong images in the pt-PT DAO page Jul 19, 2019
@huey735
Copy link
Contributor Author

huey735 commented Jul 20, 2019

I have a copy of the website running on huey735.github.io where the only difference I can see is
url: "https://huey735.github.io"
On ~/_config.yml

And it renders the urls as pt-PT, as it should, and it fetches the correct images.

@m52go
Copy link
Contributor

m52go commented Aug 6, 2019

Fixed with #201.

@m52go m52go closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants