Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing symbolic test resource links with file copies #926

Closed
wants to merge 1 commit into from

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Jan 25, 2016

@fnothaft
Copy link
Member

Actually, do we even need to copy the files? I think if we include adam-core's test jar in the test scope for the other two modules, we should be able to eliminate these files from the resource directories. I'd like to avoid having duplicate copies of files, esp. because with the SAM files, the headers sometimes need to be updated when htsjdk versions change.

@heuermh
Copy link
Member Author

heuermh commented Jan 25, 2016

That is possibly true, I don't know how we're reading files in test cases. Wouldn't take much to read resources off the classpath though.

@fnothaft
Copy link
Member

Off of the top of my head, we load them from the classpath, which is why I think the test-jar approach would work.

@heuermh
Copy link
Member Author

heuermh commented Jan 25, 2016

Yep, just got there. val path = resourcePath("small.sam"). Should only take a sec to use the test-jar.

@heuermh
Copy link
Member Author

heuermh commented Jan 25, 2016

Spits out these warnings

- unordered sam to unordered sam
2016-01-25 12:38:31 WARN  AlignmentRecordRDDFunctions:520 - Caught exception when merging via Hadoop FileSystem API:
java.lang.UnsupportedOperationException: Not implemented by the RawLocalFileSystem FileSystem implementation
2016-01-25 12:38:31 WARN  AlignmentRecordRDDFunctions:521 - Retrying as manual copy from the driver which will degrade performance.

but works fine. Closing in favor of #927.

@heuermh heuermh closed this Jan 25, 2016
@heuermh heuermh deleted the copy-test-resources branch January 25, 2016 18:41
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1069/
Test PASSed.

@fnothaft
Copy link
Member

Those warnings were added as part of https://github.com/bigdatagenomics/adam/pull/917/files. Specifically, the concat method in the Hadoop FileSystem class is much more efficient, but it's really fragile (only works on HDFS, requires all files to exactly fill blocks). If the concat path fails, we throw the warning message and retry via the slow but reliable path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants