Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.09 #577

Merged
merged 33 commits into from
Apr 16, 2021
Merged

20.09 #577

merged 33 commits into from
Apr 16, 2021

Conversation

jonas27
Copy link
Contributor

@jonas27 jonas27 commented Feb 8, 2021

No description provided.

@jonas27
Copy link
Contributor Author

jonas27 commented Feb 9, 2021

This happend on some cluster-base builds but just a few:

 #8 6.872 Hit:5 http://archive.ubuntu.com/ubuntu focal-backports InRelease
#8 7.866 Err:6 https://cvmrepo.web.cern.ch/cvmrepo/apt focal-prod InRelease
#8 7.866   403  Forbidden [IP: 188.185.87.216 443]
#8 7.873 Reading package lists...
#8 8.566 E: Failed to fetch http://cvmrepo.web.cern.ch/cvmrepo/apt/dists/focal-prod/InRelease  403  Forbidden [IP: 188.185.87.216 443]
#8 8.566 E: The repository 'http://cvmrepo.web.cern.ch/cvmrepo/apt focal-prod InRelease' is not signed.

I guess it is a problem with github or cvm

Copy link
Contributor Author

@jonas27 jonas27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happend on some cluster-base builds but just a few:

 #8 6.872 Hit:5 http://archive.ubuntu.com/ubuntu focal-backports InRelease
#8 7.866 Err:6 https://cvmrepo.web.cern.ch/cvmrepo/apt focal-prod InRelease
#8 7.866   403  Forbidden [IP: 188.185.87.216 443]
#8 7.873 Reading package lists...
#8 8.566 E: Failed to fetch http://cvmrepo.web.cern.ch/cvmrepo/apt/dists/focal-prod/InRelease  403  Forbidden [IP: 188.185.87.216 443]
#8 8.566 E: The repository 'http://cvmrepo.web.cern.ch/cvmrepo/apt focal-prod InRelease' is not signed.

I guess it is a problem with github or cvm

This happens again, annoying

@@ -1,7 +1,7 @@
FROM alpine:3.11

ENV TEST_REPO=${TEST_REPO:-https://github.com/usegalaxy-eu/workflow-testing} \
TEST_RELEASE=${TEST_RELEASE:-master}
ENV TEST_REPO=${TEST_REPO:-https://github.com/jonas27/workflow-testing} \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEFORE MERGE: Check if this is ok!

  • It comments out the data types in the workflows.
  • If not the tests fail on the metadata and throw an error on samtools wanting to scan an empty file.

@abretaud
Copy link
Collaborator

@jonas27 what's up on this PR? do you think it's ok to merge?

@abretaud
Copy link
Collaborator

The diff looks good + it can't hurt => I'm merging
Thanks @jonas27!

@abretaud abretaud merged commit 2465c63 into bgruening:20.09 Apr 16, 2021
@jonas27
Copy link
Contributor Author

jonas27 commented Apr 16, 2021

@abretaud that was too fast for me ;)
There were some tests not passing, hinting that some weird quirks were hiding somewhere. However, galaxy seemed to run quite stable, so I hope there is not going be any problems now or down the line.

@abretaud
Copy link
Collaborator

Ahah, sorry, I was too impatient! Anyway there were less red tests here than in #569 so I guess it can only be better :)
You mean tests not passing on your local machine? Anything specific to check?

@jonas27
Copy link
Contributor Author

jonas27 commented Apr 16, 2021

Nw. I was referring to the tests inside the github actions and true, it is probably better ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants