Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.09 #569

Merged
merged 72 commits into from
Apr 18, 2021
Merged

20.09 #569

merged 72 commits into from
Apr 18, 2021

Conversation

bgruening
Copy link
Owner

No description provided.

@abretaud abretaud mentioned this pull request Apr 16, 2021
@bgruening
Copy link
Owner Author

Last k8s test is missing python again:

/galaxy/database/jobs_directory/000/1/tool_script.sh: line 9: python: command not found

I'm tempted to skip that test.

@bgruening
Copy link
Owner Author

@abretaud do you recall what the problem with FTP is?

@bgruening bgruening merged commit 08ef14d into master Apr 18, 2021
@bgruening
Copy link
Owner Author

Thanks @jonas27 and @abretaud!

@bgruening bgruening deleted the 20.09 branch April 18, 2021 10:18
@abretaud
Copy link
Collaborator

Thanks for the merge!

@abretaud do you recall what the problem with FTP is?

To upload data in (default) passive mode the client needs to connect to proftpd on a random port between 30000-40000, which are not exposed by the container => fail
Active mode is not better = proftpd tries to connect to the client, but in testing environment with docker, there is some confusion between docker ip/cilent ip => fail

We could also run the container with --net=host, but it would probably mess with the rest of the tests (maybe I'm wrong here)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants