Support percentage based RGB as output format #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DennisKehrig thanks for contributing this. As the CSS spec allows percentage values inside of RGB colors this seems like a reasonable output format. In some ways I wish there was a way to handle this without adding a new function on the object (as I could see possibly wanting hsl or hsv with multiple output formats at some point). But I guess we could just cross that bridge when it comes. Do you mind adding a couple of tests to test/test.js to confirm this percentage string behavior? |
|
@bgrins: There you go! Are these sufficient? |
|
@DennisKehrig Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement in order to fix adobe/brackets#2050