[CLOSED] Add support for percentage based RGB colors to the inline color editor

[core-ai-bot]

Issue by DennisKehrig
Monday Nov 26, 2012 at 22:41 GMT
Originally opened as adobe/brackets#2212

---

Fix for #2050

---

DennisKehrig included the following code: https://github.com/adobe/brackets/pull/2212/commits

[core-ai-bot]

Comment by DennisKehrig
Monday Nov 26, 2012 at 22:42 GMT

---

Assigning@RaymondLim because he filed the issue

Hey Raymond, would you mind testing this? Thanks!

[core-ai-bot]

Comment by RaymondLim
Wednesday Nov 28, 2012 at 07:04 GMT

---

@DennisKehrig Your files are out-of-sync and I had to manually duplicate your changes in order to test the conversion to percentage rgb format.

Nice work! I wonder where you get this version of tinycolor-min.js. When I locate tinycolor in Github, I only found our current version v0.5.

I don't think your changes to the layout in the template are ok.@GarthDB and@njx Can you guys take a look at@DennisKehrig changes? He added one button and increase the width of the input text field. It's nice to have one more button to do the conversion, but we may need to have a better layout though.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Nov 28, 2012 at 12:33 GMT

---

Hey@RaymondLim, thanks for the review!

I rebased my changes on the current master.
For tinycolor, see bgrins/TinyColor#9

You're right about the UI changes, it looks weird with the aside so far to the side. In my opinion it should start right next to the sliders, above the buttons.
I increased the size of the input field to make strings like "rgba(100%, 100%, 100%, 0.65)" fit.

@GarthDB Do you want to work on that or should I take a shot at it?

[core-ai-bot]

Comment by GarthDB
Wednesday Nov 28, 2012 at 14:39 GMT

---

I'll work on it.

Sent from my iPhone

On Nov 28, 2012, at 4:33 AM, Dennis Kehrig notifications@github.com wrote:

Hey@RaymondLim, thanks for the review!

I rebased my changes on the current master.
For tinycolor, see bgrins/TinyColor#9

You're right about the UI changes, it looks weird with the aside so far to the side. In my opinion it should start right next to the sliders, above the buttons.
I increased the size of the input field to make strings like "rgba(100%, 100%, 100%, 0.65)" fit.

@GarthDB Do you want to work on that or should I take a shot at it?

—
Reply to this email directly or view it on GitHub.

[core-ai-bot]

Comment by DennisKehrig
Monday Jan 07, 2013 at 10:17 GMT

---

Rebased onto master

[core-ai-bot]

Comment by DennisKehrig
Wednesday Jan 09, 2013 at 12:54 GMT

---

Hey@GarthDB, do you have any updates for me on this?

[core-ai-bot]

Comment by peterflynn
Wednesday Mar 06, 2013 at 20:20 GMT

---

@GarthDB@DennisKehrig NJ suggested we simplify this so it essentially has no UI changes -- opening the color editor on a percentage color would show none of the existing 3 color format buttons as selected, and as you drag the sliders the number would stay in percentage format. If you click a button to change the format, then there's no way to get back to percentage format other than manually editing the code. That seems like a reasonable tradeoff between supporting this less-common format vs. keeping the UI clean & simple. Thoughts?

[core-ai-bot]

Comment by GarthDB
Wednesday Mar 06, 2013 at 20:26 GMT

---

I think that would work. I would think that if a user is using the visual color editor they may not be so concerned with whether it is percentage or not.
—
Sent from Mailbox for iPhone

On Wed, Mar 6, 2013 at 12:20 PM, Peter Flynn notifications@github.com
wrote:

##@GarthDB@DennisKehrig NJ suggested we simplify this so it essentially has no UI changes -- opening the color editor on a percentage color would show none of the existing 3 color format buttons as selected, and as you drag the sliders the number would stay in percentage format. If you click a button to change the format, then there's no way to get back to percentage format other than manually editing the code. That seems like a reasonable tradeoff between supporting this less-common format vs. keeping the UI clean & simple. Thoughts?

Reply to this email directly or view it on GitHub:
adobe/brackets#2212 (comment)

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 06, 2013 at 20:32 GMT

---

@peterflynn I think it's a good compromise!

[core-ai-bot]

Comment by DennisKehrig
Monday Mar 11, 2013 at 11:26 GMT

---

@RaymondLim UI changes removed. Note that strings like rgba(100%, 100%, 100%, 0.5) are now too long for the input box.

[core-ai-bot]

Comment by RaymondLim
Wednesday Apr 24, 2013 at 05:38 GMT

---

Sorry Dennis. You need to resolve the conflict. After you resolve it, I'll land it to master for this sprint.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Apr 24, 2013 at 23:19 GMT

---

Hey@RaymondLim, thanks for the heads up! I merged master into the branch. I needed to change the unit tests a bit, please check if that is okay.

[core-ai-bot]

Comment by RaymondLim
Thursday Apr 25, 2013 at 05:52 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by DennisKehrig
Thursday Apr 25, 2013 at 06:31 GMT

---

Thank you :)