Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scene_viewer and audio_control examples panic #16978

Closed
rparrett opened this issue Dec 26, 2024 · 0 comments · Fixed by #16983
Closed

scene_viewer and audio_control examples panic #16978

rparrett opened this issue Dec 26, 2024 · 0 comments · Fixed by #16983
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Milestone
0.15.1

Comments

@rparrett
Copy link
Contributor

rparrett commented Dec 26, 2024 •
edited
Loading

Bevy version

main, bisected to #16638

What you did

cargo run --example scene_viewer
cargo run --example audio_control

What went wrong

thread 'main' panicked at /Users/me/src/bevy/crates/bevy_ecs/src/system/function_system.rs:216:28:
scene_viewer::camera_controller::run_camera_controller could not access system parameter Single<(&mut Transform, &mut CameraController), With<Camera>>

thread 'main' panicked at /Users/me/src/bevy/crates/bevy_ecs/src/system/function_system.rs:216:28:
audio_control::update_speed could not access system parameter Single<AudioSink, With<MyMusic>>

Additional information

Related to #16959
@rparrett rparrett added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Dec 26, 2024
@mockersf mockersf added this to the 0.15.1 milestone Dec 26, 2024
@rparrett rparrett modified the milestone: 0.15.1 Dec 26, 2024
@rparrett rparrett mentioned this issue Dec 26, 2024
Merged
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Dec 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 26, 2024
@rparrett @mockersf
Fix panics in scene_viewer and audio_control (#16983)
78d2149 
# Objective

Fixes #16978

While testing, discovered that the morph weight interface in
`scene_viewer` has been broken for a while (panics when loaded model has
morph weights), probably since #15591. Fixed that too.

While testing, saw example text in morph interface with [wrong
padding](https://bevyengine.org/learn/contribute/helping-out/creating-examples/#visual-guidelines).
Fixed that too. Left the small font size because there may be a lot of
morphs to display, so that seems intentional.

## Solution

Use normal queries and bail early

## Testing

Morph interface can be tested with
```
cargo run --example scene_viewer assets/models/animated/MorphStressTest.gltf
```

## Discussion

I noticed that this fix is different than what is happening in #16976.
Feel free to discard this for an alternative fix. I opened this anyway
to document the issue with morph weight display.

This is on top of #16966 which is required to test.

---------

Co-authored-by: François Mockers <francois.mockers@vleue.com>
Co-authored-by: François Mockers <mockersf@gmail.com>
mockersf added a commit that referenced this issue Jan 3, 2025
@rparrett @mockersf
Fix panics in scene_viewer and audio_control (#16983)
6138575 
Fixes #16978

While testing, discovered that the morph weight interface in
`scene_viewer` has been broken for a while (panics when loaded model has
morph weights), probably since #15591. Fixed that too.

While testing, saw example text in morph interface with [wrong
padding](https://bevyengine.org/learn/contribute/helping-out/creating-examples/#visual-guidelines).
Fixed that too. Left the small font size because there may be a lot of
morphs to display, so that seems intentional.

Use normal queries and bail early

Morph interface can be tested with
```
cargo run --example scene_viewer assets/models/animated/MorphStressTest.gltf
```

I noticed that this fix is different than what is happening in #16976.
Feel free to discard this for an alternative fix. I opened this anyway
to document the issue with morph weight display.

This is on top of #16966 which is required to test.

---------

Co-authored-by: François Mockers <francois.mockers@vleue.com>
Co-authored-by: François Mockers <mockersf@gmail.com>
ecoskey pushed a commit to ecoskey/bevy that referenced this issue Jan 6, 2025
@rparrett @mockersf @ecoskey
Fix panics in scene_viewer and audio_control (bevyengine#16983)
e2925eb 
# Objective

Fixes bevyengine#16978

While testing, discovered that the morph weight interface in
`scene_viewer` has been broken for a while (panics when loaded model has
morph weights), probably since bevyengine#15591. Fixed that too.

While testing, saw example text in morph interface with [wrong
padding](https://bevyengine.org/learn/contribute/helping-out/creating-examples/#visual-guidelines).
Fixed that too. Left the small font size because there may be a lot of
morphs to display, so that seems intentional.

## Solution

Use normal queries and bail early

## Testing

Morph interface can be tested with
```
cargo run --example scene_viewer assets/models/animated/MorphStressTest.gltf
```

## Discussion

I noticed that this fix is different than what is happening in bevyengine#16976.
Feel free to discard this for an alternative fix. I opened this anyway
to document the issue with morph weight display.

This is on top of bevyengine#16966 which is required to test.

---------

Co-authored-by: François Mockers <francois.mockers@vleue.com>
Co-authored-by: François Mockers <mockersf@gmail.com>
mrchantey pushed a commit to mrchantey/bevy that referenced this issue Feb 4, 2025
@rparrett @mockersf @mrchantey
Fix panics in scene_viewer and audio_control (bevyengine#16983)
066aa55 
# Objective

Fixes bevyengine#16978

While testing, discovered that the morph weight interface in
`scene_viewer` has been broken for a while (panics when loaded model has
morph weights), probably since bevyengine#15591. Fixed that too.

While testing, saw example text in morph interface with [wrong
padding](https://bevyengine.org/learn/contribute/helping-out/creating-examples/#visual-guidelines).
Fixed that too. Left the small font size because there may be a lot of
morphs to display, so that seems intentional.

## Solution

Use normal queries and bail early

## Testing

Morph interface can be tested with
```
cargo run --example scene_viewer assets/models/animated/MorphStressTest.gltf
```

## Discussion

I noticed that this fix is different than what is happening in bevyengine#16976.
Feel free to discard this for an alternative fix. I opened this anyway
to document the issue with morph weight display.

This is on top of bevyengine#16966 which is required to test.

---------

Co-authored-by: François Mockers <francois.mockers@vleue.com>
Co-authored-by: François Mockers <mockersf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
Milestone
0.15.1
Development

Successfully merging a pull request may close this issue.

Fix panics in scene_viewer and audio_control rparrett/bevy
3 participants
@rparrett @alice-i-cecile @mockersf