Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21445 - Updated the GET and PUT configuration calls #2849

Merged

Conversation

JazzarKarim
Copy link
Collaborator

Issue #:
bcgov/entity#21445

Description of changes:
Since we're only using the NUM_DISSOLUTIONS_ALLOWED in the UI, there are some changes being made to be more efficient.

  1. The GET call will now support params to grab ONLY what we need.
  2. I'm putting now ONLY the object that I need which is when the name is NUM_DISSOLUTIONS_ALLOWED

This is a Quality of Life fix to improve things here.

Note: I'm waiting for bcgov/lear#2731 to be merged before I change this out of draft.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@JazzarKarim JazzarKarim self-assigned this Jun 3, 2024
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seeker25
Copy link
Collaborator

seeker25 commented Jun 4, 2024

It's merged gogogoo!

@JazzarKarim
Copy link
Collaborator Author

It's merged gogogoo!

hahahhahaha
giphy

@JazzarKarim JazzarKarim marked this pull request as ready for review June 4, 2024 17:04
@JazzarKarim JazzarKarim merged commit e708617 into bcgov:main Jun 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants