Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth WEB - Update the GET and PUT calls for configurations #21445

Closed
3 tasks done
JazzarKarim opened this issue May 28, 2024 · 2 comments
Closed
3 tasks done

Auth WEB - Update the GET and PUT calls for configurations #21445

JazzarKarim opened this issue May 28, 2024 · 2 comments
Assignees
Labels
Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team

Comments

@JazzarKarim
Copy link
Collaborator

JazzarKarim commented May 28, 2024

As of right now, the GET call for configurations is grabbing all the configuration items although the UI doesn't use most of them.

As for the PUT call, we're putting the entire configurations array although only one thing has changed and that's the value of the dissolution batch size. We need to only change that.

Need to handle:

@JazzarKarim JazzarKarim added Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team blocked labels May 28, 2024
@JazzarKarim JazzarKarim self-assigned this Jun 3, 2024
@vishnup0422
Copy link
Collaborator

vishnup0422 commented Jun 4, 2024

Tested in Dev and able to query with specific param for retrieving that configuration.

GET :

https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/admin/configurations?names=NUM_DISSOLUTIONS_ALLOWED

Screenshot 2024-06-04 at 10.53.58 AM.png

Screenshot 2024-06-04 at 10.54.10 AM.png

Screenshot 2024-06-04 at 11.19.02 AM.png

Now we can just send a configuration that needs to be updated in the array instead of sending all the configurations list.
PUT:

Screenshot 2024-06-04 at 11.00.49 AM.png

@vishnup0422
Copy link
Collaborator

vishnup0422 commented Jun 6, 2024

Verified the GET and PUT operations in Test env and working as expected.

Screenshot 2024-06-06 at 10.08.15 AM.png

Screenshot 2024-06-06 at 10.08.01 AM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

3 participants