25066-Update-allowable-BEN-conversions

[meawong]

Issue #: /bcgov/entity#25066

Description of changes:

• update redirect logic for BENs according to these flows:
  1. Starting point in LEAR => resulting company in Lear
  2. Starting point in COLIN and resulting is not BEN => redirect to COLIN
  3. Starting point in COLIN and resulting is BEN => display the "Contact Us" text

Example 1 - LEAR

Example 2 - COLIN -> NOT BEN

Example 3 - COLIN -> BEN

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

[meawong]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-790-3i735qrh.web.app

LEAR ex: BC0884813
COLIN ex: BC0808036

[meawong]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-790-3i735qrh.web.app

[severinbeauvais]

LGTM!

Thanks for the test screenshots. I also tested this and it looks great!

[eve-git]

We are preparing for next week's release for the NRO decommissioning. You might want to check with Omid to confirm if it's okay to merge the code into the main branch.

[severinbeauvais]

We are preparing for next week's release for the NRO decommissioning. You might want to check with Omid to confirm if it's okay to merge the code into the main branch.

This code change should be OK as it is in Namerequest UI and has nothing to do with NRO decommissioning.

[severinbeauvais]

Please test this functionality while not logged in.

It looks to me like checkBusinessInLear uses fetchBusiness, and that function's header comment says you have to be logged in, ie:

It looks like this update doesn't work when not logged in:

Could this ticket be related? bcgov/entity#25118

[severinbeauvais]

I'm confused. In the console it shows this:

but in the Network tab it clearly shows the business call succeeded:

and