25067 Updated storage sync check #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
commented
Dec 24, 2024
| @@ -18,7 +18,7 @@ VUE_APP_LEGAL_API_URL="https://legal-api-dev.apps.silver.devops.gov.bc.ca" | |||
| VUE_APP_LEGAL_API_VERSION_2="/api/v2" | |||
| VUE_APP_NAMEX_API_URL="https://namex-dev.apps.silver.devops.gov.bc.ca" | |||
| VUE_APP_NAMEX_API_VERSION="/api/v1" | |||
| VUE_APP_STATUS_API_URL="https://status-api-dev.apps.silver.devops.gov.bc.ca" | |||
| VUE_APP_STATUS_API_URL="https://status-api-dev.apps.gold.devops.gov.bc.ca" | |||
There was a problem hiding this comment.
Note to developers: please update your .env file as needed.
severinbeauvais
commented
Dec 24, 2024
| @@ -16,7 +16,7 @@ export class UpdateUserMixin extends Vue { | |||
| } | |||
| } catch (err) { | |||
| // just log the error -- no need to halt app | |||
| console.log('Launch Darkly update error =', err) // eslint-disable-line no-console | |||
| console.log('Error updating user =', err) // eslint-disable-line no-console | |||
There was a problem hiding this comment.
The error could be in fetchUserInfo or updateLaunchDarkly so I generalized this message.
severinbeauvais
commented
Dec 24, 2024
JazzarKarim
approved these changes
Dec 30, 2024
- app version = 5.5.20 - updated updateUser error text - check SESSION_SYNCED before fetching user info - misc cleanup
|
/gcbrun |
severinbeauvais
commented
Jan 3, 2025
| const url = `${this.authApiUrl}/users/@me` | ||
| // don't fetch user info if session isn't synced (ie, user is not logged in) | ||
| // to pre-empt a console error and Sentry log | ||
| if (sessionStorage.getItem('SESSION_SYNCED') !== 'true') return null |
There was a problem hiding this comment.
I'm now checking a different session variable, same as in auth-web, ie.
I also left in the check for a KC token, but that's probably redundant. Or overly safe, you decide 😆
|
Temporary Url for review: https://namerequest-dev--pr-789-x6o9lylg.web.app |
bolyachevets
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#25067
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).