- updated example Status API URL (#789)

- app version = 5.5.20
- updated updateUser error text
- check SESSION_SYNCED before fetching user info
- misc cleanup

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>

app/.env.example

@@ -18,7 +18,7 @@ VUE_APP_LEGAL_API_URL="https://legal-api-dev.apps.silver.devops.gov.bc.ca"
 VUE_APP_LEGAL_API_VERSION_2="/api/v2"
 VUE_APP_NAMEX_API_URL="https://namex-dev.apps.silver.devops.gov.bc.ca"
 VUE_APP_NAMEX_API_VERSION="/api/v1"
-VUE_APP_STATUS_API_URL="https://status-api-dev.apps.silver.devops.gov.bc.ca"
+VUE_APP_STATUS_API_URL="https://status-api-dev.apps.gold.devops.gov.bc.ca"
 VUE_APP_STATUS_API_VERSION="/api/v1"
 VUE_APP_REGISTRIES_SEARCH_API_URL="https://bcregistry-dev.apigee.net/registry-search"
 VUE_APP_REGISTRIES_SEARCH_API_VERSION="/api/v1"

app/package.json

@@ -1,6 +1,6 @@
 {
   "name": "name-request",
-  "version": "5.5.19",
+  "version": "5.5.20",
   "private": true,
   "appName": "Name Request UI",
   "sbcName": "SBC Common Components",

app/src/mixins/update-user-mixin.ts

@@ -16,7 +16,7 @@ export class UpdateUserMixin extends Vue {
       }
     } catch (err) {
       // just log the error -- no need to halt app
-      console.log('Launch Darkly update error =', err) // eslint-disable-line no-console
+      console.log('Error updating user =', err) // eslint-disable-line no-console
     }
   }
 

app/src/services/auth-services.ts

@@ -53,24 +53,22 @@ export default class AuthServices {
    * Throws on error.
    */
   static async fetchUserInfo (): Promise<any> {
-    // PREVENT_STORAGE_SYNC flag is set during signout in sbc common components
-    // when session is state cleared, as a mechanism to prevent returning async
-    // functions to set tokens
-    if (sessionStorage.getItem('PREVENT_STORAGE_SYNC')) return null
-    const url = `${this.authApiUrl}/users/@me`
+    // don't fetch user info if session isn't synced (ie, user is not logged in)
+    // to pre-empt a console error and Sentry log
+    if (sessionStorage.getItem('SESSION_SYNCED') !== 'true') return null
+
+    // don't fetch user info if there is no KC token (safety check)
     const token = sessionStorage.getItem('KEYCLOAK_TOKEN')
-    if (token) {
-      const headers = {
-        Authorization: `Bearer ${token}`
-      }
-      return axios.get(url, { headers: headers })
-        .then(response => {
-          if (response?.data) return response.data
-          throw new Error('Invalid user info')
-        })
-    } else {
-      return null
-    }
+    if (!token) return null
+
+    const url = `${this.authApiUrl}/users/@me`
+    const headers = { Authorization: `Bearer ${token}` }
+
+    return axios.get(url, { headers: headers })
+      .then(response => {
+        if (response?.data) return response.data
+        throw new Error('Invalid user info')
+      })
   }
 
   /**