Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21696-fix broken code coverage uploads in CIs #2767

Merged

Conversation

eason-pan-bc
Copy link
Collaborator

Issue #: /bcgov/entity#21696

Description of changes:

  • Update Codecov version to use v4, and add token to them
  • Add Codecov section for Furnishings Job CI and Involuntary Dissolutions Job CI

Fixed and verified for legal-api before, PRs:
Add token and using v4: #2759
Verify it works for legal-api: #2760

Will create another test PR with other CIs after this PR gets merged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@AimeeGao AimeeGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looking forward to the other CIs being addressed.

@chenhongjing
Copy link
Collaborator

Others look good!

@eason-pan-bc
Copy link
Collaborator Author

Added Entity BN, Entity Digital Credentials, Furnishings Job, Involuntary Dissolutions flags to codecov.yaml, and removed datareset flag from it.

@eason-pan-bc eason-pan-bc merged commit 6192b01 into bcgov:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants