Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE - Fix broken code coverage uploads in all CI pipelines #21696

Closed
11 tasks done
argush3 opened this issue Jun 7, 2024 · 3 comments
Closed
11 tasks done

BE - Fix broken code coverage uploads in all CI pipelines #21696

argush3 opened this issue Jun 7, 2024 · 3 comments
Assignees
@eason-pan-bc
Labels
Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team techdebt

Comments

@argush3
Copy link
Collaborator

argush3 commented Jun 7, 2024 •
edited by eason-pan-bc
Loading

All of the CI pipelines in the LEAR repo that upload coverage reports to codegov are currently broken.

This is happening because codegov started requiring a token to be passed in recently.

Updates will need to be made to the GH CI to pass in the codegov token.

TODOs

  • Add codegov token for each broken GH CI workflow:
    • Colin API CI
    • Email Reminder Job Cl (Not going to fix due to the section has been commented out before)
    • Entity BN CI
    • Entity Digital Credentials Cl
    • Entity Emailer Cl
    • Entity Filer Cl
    • Entity Pay CI
    • Furnishings Job Cl
    • Future Effective Filings Job Cl (Not going to fix due to the section has been commented out before)
    • Involuntary Dissolutions Job Cl
    • Legal API CI
    • Update Colin Filings Job Cl (Not going to fix due to the section has been commented out before)
    • Update Legal Filings Job Cl (Not going to fix due to the section has been commented out before)
  • Verify each previous broken CI is able to upload code coverage report

Example of the issue
https://github.com/bcgov/lear/actions/runs/9421816173/job/25956732038
image.png

Change req'd is probably something like this for each CI under GH CI folder:

https://github.com/bcgov/lear/blob/2ee5b9a1ba23588306785dd81f6b3bfa360272ac/.github/workflows/legal-api-ci.yml#L99-L105
image.png
@argush3 argush3 added Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team labels Jun 7, 2024
@argush3
Copy link
Collaborator Author

argush3 commented Jun 7, 2024

cc: @davemck513 @vishnup0422

@eason-pan-bc eason-pan-bc self-assigned this Jun 14, 2024
This was referenced Jun 14, 2024
Merged
Closed
Merged
Closed
Merged
Closed
@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Jun 18, 2024 •
edited
Loading

Verification update:
Colin API - Successfully uploaded to Codecov ✔️ , linting issue
Entity BN - All Good ✅
Entity Digital Credentials - All Good ✅
Entity Emailer - All Good ✅
Entity Filer - Unable to verify 🟡 , issue running tests (discussed, will be fixed in future tickets)
Entity Pay - Unable to verify 🟡 , issue running tests (not using it anymore with the latest pay queue upgrade release)
Furnishings Job - Unable to verify 🟡 , issue running tests (discussed, will be fixed in future tickets)
Involuntary Dissolution Job - All Good ✅
Legal API - All Good ✅

@vishnup0422
Copy link
Collaborator

This looks good as the pipelines are passing and uploading to codecov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eason-pan-bc eason-pan-bc

Labels
Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@argush3 @ketaki-deodhar @eason-pan-bc @vishnup0422