Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namex API - missing conversion request type (BEN to CC) #24193

Closed
eve-git opened this issue Nov 1, 2024 · 9 comments
Closed

Namex API - missing conversion request type (BEN to CC) #24193

eve-git opened this issue Nov 1, 2024 · 9 comments
Assignees
Labels
bug Something isn't working Dependency To highlight the dependency(intra team, external, third parties) Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. High Priority Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex NRO NRO Replacement Priority3

Comments

@eve-git
Copy link
Collaborator

eve-git commented Nov 1, 2024

Work on this ticket at the same time as #23382.

There are 8 name request types for conversion (CNV):

  1. BECR - Benefit Company → BC Limited
  2. BECV - BC Limited → Benefit Company
  3. CCV - BC Limited → Community Contribution Company
  4. CSSO - Society - Conversion of a Special Act not in scope for this ticket
  5. UC - BC Limited → Unlimited Liability Company
  6. ULCB - Unlimited Liability Company → BC Limited
  7. ULBE - Unlimited Liability Company → Benefit Company

One is missed:
8. BECC - Benefit Company → Community Contribution Company (new request type that introduced in this ticket)

Corresponding changes may be required in Name Request and/or Name Examination.
See also Namerequest UI ticket: #24190
See also Name Examination UI ticket: #24255

@eve-git eve-git added the Names Team Name Request Name Examination Team label Nov 1, 2024
@severinbeauvais severinbeauvais added bug Something isn't working High Priority labels Nov 1, 2024
@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 1, 2024

I set this as high priority because it's blocking continuation in alteration testing (ticket #23380). see updated comments below

@severinbeauvais severinbeauvais added Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Dependency To highlight the dependency(intra team, external, third parties) labels Nov 5, 2024
@severinbeauvais severinbeauvais changed the title Namex - missing conversion request type Namex API - missing conversion request type Nov 5, 2024
@severinbeauvais
Copy link
Collaborator

It has been decided that alteration of business type will be part of the Directed Launch. Therefore, this ticket can now be worked on.

@severinbeauvais
Copy link
Collaborator

This is high priority for Directed Launch.

@severinbeauvais
Copy link
Collaborator

PO has decided that this is low priority because we haven't seen any of these in Prod in the last few years. We can work on this later.

@ozamani9gh ozamani9gh added Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. and removed Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Nov 7, 2024
@ozamani9gh
Copy link
Collaborator

Omid to discuss with @severinbeauvais about who should complete work.

@ozamani9gh ozamani9gh self-assigned this Nov 12, 2024
@severinbeauvais
Copy link
Collaborator

I believe there is just 1 conversion NR type missing (BEN to CC). I expect the code has a table with the values, so it should be one line of code to update this.

What I can't tell you is if this is absolutely required for Directed Launch. Please ask Olga.

@OlgaPotiagalova OlgaPotiagalova changed the title Namex API - missing conversion request type Namex API - missing conversion request type (BEN to CC) Nov 13, 2024
@OlgaPotiagalova
Copy link
Collaborator

@ozamani9gh, @severinbeauvais this is not required for directed launch. Such alteration types did not occur so far, so it is low probability of happening.

@OlgaPotiagalova
Copy link
Collaborator

We will review it before the MVP release

@severinbeauvais
Copy link
Collaborator

Test Notes

I recommend testing this ticket along with #23382.

Please verify that creating all types of conversion NRs functions correctly.

Specifically:

  1. BECV - BC Limited → Benefit Company
  2. CCV - BC Limited → Community Contribution Company
  3. UC - BC Limited → Unlimited Liability Company
  4. BECR - Benefit Company → BC Limited
  5. BECC - Benefit Company → Community Contribution Company
  6. ULCB - Unlimited Liability Company → BC Limited
  7. ULBE - Unlimited Liability Company → Benefit Company

and the continued-in equivalents:

  1. BECV - continued-in BC Limited → continued-in Benefit Company
  2. CCV - continued-in BC Limited → continued-in Community Contribution Company
  3. UC - continued-in BC Limited → continued-in Unlimited Liability Company
  4. BECR - continued-in Benefit Company → continued-in BC Limited
  5. BECC - continued-in Benefit Company → continued-in Community Contribution Company
  6. ULCB - continued-in Unlimited Liability Company → continued-in BC Limited
  7. ULBE - continued-in Unlimited Liability Company → continued-in Benefit Company

@ozamani9gh ozamani9gh added NameX NameX and related services proxied via namex NRO NRO Replacement labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Dependency To highlight the dependency(intra team, external, third parties) Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. High Priority Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex NRO NRO Replacement Priority3
Projects
None yet
Development

No branches or pull requests

4 participants