Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namerequest UI: BEN can't convert to CCC + continued in businesses can't alter their business type #24190

Closed
severinbeauvais opened this issue Nov 1, 2024 · 5 comments
Assignees
Labels
bug Something isn't working Dependency To highlight the dependency(intra team, external, third parties) Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Name Request Names Team Name Request Name Examination Team Priority3

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 1, 2024

There are 2 things to fix in this ticket:

  1. add missing entry for BEN to convert to a CCC
  2. add entries for continued in types to convert (same list as regular companies)

In Dev:
image.png

Here are the updated requirements:

Original type New type NR request type code
BC Limited Benefit Company BECV
BC Limited Unlimited Liability Company UC
BC Limited Community Contribution Company CCV
Benefit Company BC Limited BECR
Benefit Company Community Contribution Company new code = BECC
Unlimited Liability Company BC Limited ULCB
Unlimited Liability Company Benefit Company ULBE

(and all the continued-in equivalents)

@severinbeauvais severinbeauvais added bug Something isn't working Dependency To highlight the dependency(intra team, external, third parties) Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Name Request Names Team Name Request Name Examination Team labels Nov 1, 2024
@severinbeauvais
Copy link
Collaborator Author

The alterations (conversions) are configured here: https://github.com/bcgov/namerequest/blob/main/app/src/list-data/conversion-types.ts

@severinbeauvais severinbeauvais self-assigned this Nov 1, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 1, 2024

The new BEN -> CCC request type code has not yet been approved or configured in Namex API. I will post more when I get an answer to this. We get to define new codes, so we will use BECC as the code for BEN -> CCC conversion.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 4, 2024

I've done a bit of work on this already.

The Pull Request is bcgov/namerequest#780.

@severinbeauvais severinbeauvais changed the title Namerequest UI: continued in businesses can't alter their business type Namerequest UI: BEN can't convert to CCC + continued in businesses can't alter their business type Nov 5, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 6, 2024

It has been decided that alteration of business type will be part of the Directed Launch. Therefore, this ticket can now be worked on.

(Anyone can pull the PR code above and finish it.)

@severinbeauvais
Copy link
Collaborator Author

This is high priority for Directed Launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Dependency To highlight the dependency(intra team, external, third parties) Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Name Request Names Team Name Request Name Examination Team Priority3
Projects
None yet
Development

No branches or pull requests

3 participants