Legal API: fix alteration of company type issues

[severinbeauvais]

See results from #23941.

Steps to Reproduce:

1. Open a BC numbered business (impacting regular and continued-in)
2. Start a business type alteration.
3. Select BC Community Contribution Company from dropdown (i.e. try to alter BC -> CC or C -> CCC).
4. Proceed with regular filing workflow.
5. Click File and Pay button.
6. Unable to save Filing error pop-up appears.

Edit: Ensure the following works:

• BC -> BEN
• BC -> ULC
• BC -> CC
• BEN -> BC
• BEN -> CC (updated legal api to allow)
• ULC -> BC
• ULC -> BEN
• C -> CBEN
• C -> CUL
• C -> CCC
• CBEN -> C
• CBEN -> CCC (updated legal api to allow)
• CUL -> C
• CUL -> CBEN

Also, ensure the above codes work for C, CBEN, CCC and CUL business types. Edit: Updated above codes to list every allowable alteration in lear. If any are missing let me know.

[meawong]

Steps to Reproduce:

1. Open a BC numbered business (impacting regular and continued-in)
2. Start a business type alteration.
3. Select BC Community Contribution Company from dropdown (i.e. try to alter BC -> CC or C -> CCC).
4. Proceed with regular filing workflow.
5. Click File and Pay button.
6. Unable to save Filing error pop-up appears.

Alteration attempted on BC0883647 from screenshots.

[severinbeauvais]

Here are the updated requirements.

1. BC -> BEN
2. BC -> ULC
3. BC -> CC
4. BEN -> BC
5. BEN -> CC
6. ULC -> BC
7. ULC -> BEN

(and all the continued-in equivalents)

[vysakh-menon-aot]

@OlgaPotiagalova @vikas-gov Since we are enabling BEN->CC alteration, we need to document it somewhere that these businesses will be out of sync with COLIN until we introduce an equivalent filing type in COLIN

[severinbeauvais]

@OlgaPotiagalova @vikas-gov Since we are enabling BEN->CC alteration, we need to document it somewhere that these businesses will be out of sync with COLIN until we introduce an equivalent filing type in COLIN

How about another sync ticket?

[vysakh-menon-aot]

@OlgaPotiagalova @vikas-gov Since we are enabling BEN->CC alteration, we need to document it somewhere that these businesses will be out of sync with COLIN until we introduce an equivalent filing type in COLIN

How about another sync ticket?

That's needed for sure. I was saying either we need to disable this using FF in PROD (unless we are ok with out of sync data)

[severinbeauvais]

I was saying either we need to disable this using FF in PROD (unless we are ok with out of sync data)

If we don't expect many (or any) business conversions from BEN to CC then we could do nothing ... but that's an @OlgaPotiagalova decision. What's the risk if this does happen?

How much effort is creating an equivalent filing type in COLIN?

[vysakh-menon-aot]

Impact: Will fail to sync the specific alteration and subsequent filings in that business.

Home team has to introduce this filing type and update all the relevant messaging (BN, MRAS, or any other). Once its in place we can update colin-api with the new filing type.

[vishnup0422]

BC -> BEN

BC Business: BC0883711

BC-> CC

Private Zenhub Video

BEN -> BC

BC -> ULC

Private Zenhub Video

ULC -> BC

BEN -> CC

Private Zenhub Video

ULC -> BEN

[vishnup0422]

Continued In Limited Company -> CCC

Private Zenhub Video

Continued In BEN -> CCC

Private Zenhub Video