Alteration of company type - determine and test requirements

[severinbeauvais]

This ticket is to determine the requirement and what's broken (if anything).

Edit UI may be allowing company type changes that should not be allowed. A new ticket should be created as needed.

Legal API may be blocking company type changes that should be allowed. A new ticket should be created as needed.

Requirements from #16328:

• BC to BEN, ULC, or CC via Alteration filing (Patty)
• BEN to BC or CC via Alteration filing (Jenny)
• ULC to BC via Alteration filing (Dana)

SB says: I believe BEN -> CC should not be allowed NOTE: requirement has changed! see comments below

SB says: I believe ULC -> BEN should be allowed -- CONFIRMED

[severinbeauvais]

Numbered Businesses

X	BC	BEN	CC	ULC
BC	⬛	✓	fix in legal-api	✓
BEN	✓	⬛	fix in legal-api	⬛
CC	⬛	⬛	⬛	⬛
ULC	✓	✓	⬛	⬛

Named Businesses

X	BC	BEN	CC	ULC
BC	⬛	✓	✓	✓
BEN	✓	⬛	fix in namerequest	⬛
CC	⬛	⬛	⬛	⬛
ULC	✓	✓	⬛	⬛

Continued-In Numbered Businesses

X	C	CBEN	CC	CUL
C	⬛	✓	fix in legal-api	✓
CBEN	✓	⬛	fix in legal-api	⬛
CC	⬛	⬛	⬛	⬛
CUL	✓	✓	⬛	⬛

Continued-In Named Businesses

X	C	CBEN	CC	CUL
C	⬛	✓	fix in namerequest	fix in namerequest
CBEN	✓	⬛	fix in namerequest	⬛
CC	⬛	⬛	⬛	⬛
CUL	fix in namerequest	fix in namerequest	⬛	⬛

[severinbeauvais]

@meawong From Legal API:

valid_type_changes = {
        Business.LegalTypes.COOP.value: [Business.LegalTypes.COOP.value],
        Business.LegalTypes.BCOMP.value: [Business.LegalTypes.BCOMP.value,
                                          Business.LegalTypes.COMP.value],
        Business.LegalTypes.COMP.value: [Business.LegalTypes.COMP.value,
                                         Business.LegalTypes.BCOMP.value,
                                         Business.LegalTypes.BC_ULC_COMPANY.value,
                                         Business.LegalTypes.BC_CCC.value],
        Business.LegalTypes.BC_CCC.value: [Business.LegalTypes.BC_CCC.value],
        Business.LegalTypes.BC_ULC_COMPANY.value: [Business.LegalTypes.BC_ULC_COMPANY.value,
                                                   Business.LegalTypes.BCOMP.value,
                                                   Business.LegalTypes.COMP.value],
        Business.LegalTypes.BCOMP_CONTINUE_IN.value: [Business.LegalTypes.BCOMP_CONTINUE_IN.value,
                                                      Business.LegalTypes.CONTINUE_IN.value],
        Business.LegalTypes.CONTINUE_IN.value: [Business.LegalTypes.CONTINUE_IN.value,
                                                Business.LegalTypes.BCOMP_CONTINUE_IN.value,
                                                Business.LegalTypes.ULC_CONTINUE_IN.value,
                                                Business.LegalTypes.CCC_CONTINUE_IN.value],
        Business.LegalTypes.CCC_CONTINUE_IN.value: [Business.LegalTypes.CCC_CONTINUE_IN.value],
        Business.LegalTypes.ULC_CONTINUE_IN.value: [Business.LegalTypes.ULC_CONTINUE_IN.value,
                                                    Business.LegalTypes.BCOMP_CONTINUE_IN.value,
                                                    Business.LegalTypes.CONTINUE_IN.value]
    }

[severinbeauvais]

Megan is working on this ticket.

[severinbeauvais]

Please also:

• include the 4 continued-in entity types (which will result in 6 more allowed type alterations)
• test named and numbered businesses for all 12
• test the ones that should work and capture filing errors from Legal API
• report out what needs to be fixed; we will create new tickets accordingly

[severinbeauvais]

I have created #24040 and #24041 to fix issues in UI/Legal API found by THIS ticket.

[severinbeauvais]

Here are the updated requirements.

1. BC -> BEN
2. BC -> ULC
3. BC -> CC
4. BEN -> BC
5. BEN -> CC
6. ULC -> BC
7. ULC -> BEN

(and all the continued-in equivalents)

@meawong , could you please update the tables above?

@vysakh-menon-aot , FYI. I will update #24041 (Legal API ticket).

[severinbeauvais]

@meawong , I have moved #24040 back to Sprint Backlog since it implemented an incorrect change and requires another change.