Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint, Typescript, StoryBook, Vite #16463

Closed
14 of 20 tasks
Mihai-QuickSilverDev opened this issue May 19, 2023 · 3 comments
Closed
14 of 20 tasks

Upgrade eslint, Typescript, StoryBook, Vite #16463

Mihai-QuickSilverDev opened this issue May 19, 2023 · 3 comments
Assignees
Labels
ENTITY Business Team NON-RELEASE For tickets that aren't tied to a release

Comments

@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented May 19, 2023

  • Upgrade repo to latest versions < Vue3 (ESLint, Typescript, etc)
  • Fix Breadcrumb unit tests
  • Fix FolioNumberInput unit tests
  • Fix ApprovalType unit tests
  • Fix ShareStructure unit tests
  • Fix EditShareStructure unit tests exclude for now (new ticket)
  • Fix WebChat unit tests exclude for now (will be deleted anyway)
  • Fix CorrectName unit test
  • Fix vue-debounce-decorator dependency (BusinessLookup + DetailComment)
  • Fix CompletingParty unit tests BaseAddress issue
  • Fix FeeSummary unit tests SbcFeeSummary issue
  • Research what is needed to upgrade Storybook
  • Change from Vue-CLI/Webpack to Vite
  • Run latest Storybook (on Vue 2.7 + Vite)
  • Get eslint working with Vite
  • Get unit testing working with Vite
  • Research and implement what is needed to upgrade Lerna (from ^5.6.2 to ^7.1.1) see Upgrade Lerna - DO THIS FIRST #17123
  • Upgrade Repo to Vue 3 see Upgrade a component to Vue3 #17124
  • Create tickets in this Story for other worked required
  • Rebuild Storybook and commit changes (does not need to be reviewed)
@severinbeauvais
Copy link
Collaborator

Lint issues found while attempting to upgrade to Vue3: https://app.zenhub.com/files/157936592/c87886d0-7aca-4d5b-aa15-3d2be5c8ba4d/download

@severinbeauvais severinbeauvais changed the title Investigate what is needed Investigate what is needed (StoryBook, Vite, etc) Jul 18, 2023
@severinbeauvais severinbeauvais changed the title Investigate what is needed (StoryBook, Vite, etc) Upgrade eslint, Typescript, StoryBook, Vite Jul 18, 2023
@severinbeauvais
Copy link
Collaborator

Test Notes

There's not much to QA here. This is an upgrade to the framework/tools such as ESLint, Storybook, etc. There are virtually no (functional) changes to the components themselves (which get imported and built in a host web app).

I guess you could test that all components display correctly, except for the following tickets:
#17115
#17139

@severinbeauvais
Copy link
Collaborator

This ticket does not get released directly. The components in here are individually published to npm, from which a host app imports them and builds them. They are therefore released as part of the web app that uses them.

@severinbeauvais severinbeauvais added the NON-RELEASE For tickets that aren't tied to a release label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team NON-RELEASE For tickets that aren't tied to a release
Projects
None yet
Development

No branches or pull requests

2 participants