Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Lerna - DO THIS FIRST #17123

Closed
3 tasks done
severinbeauvais opened this issue Jul 18, 2023 · 3 comments
Closed
3 tasks done

Upgrade Lerna - DO THIS FIRST #17123

severinbeauvais opened this issue Jul 18, 2023 · 3 comments
Assignees
Labels
ENTITY Business Team techdebt

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jul 18, 2023

  • Research and implement what is needed to upgrade Lerna (from ^5.6.2 to ^7.4.1)
  • Create a feature-vue3 branch
  • Update Lerna in feature branch
    • do not publish anything yet SB says we can test this by upgrading a simple component by 1 patch version
    • up-version each component as it's upgraded (future tickets)
@severinbeauvais
Copy link
Collaborator Author

@kialj876 @cameron-eyds @JazzarKarim @seeker25

Per our discussion, we need to determine whether Lerna can up-version new components (eg, 3.x) in a feature branch AND ALSO keep up-versioning the old components (eg, 2.x) in the main branch.

If so, then we can create a feature branch and upgrade each component there to Vue3, and publish them individually, until we are ready to merge the feature branch into main.

If not, then we will have to look at alternatives for upgrading components individually (possibly in main branch, or possibly in a separate repo altogether).

@severinbeauvais severinbeauvais changed the title Upgrade Lerna Upgrade Lerna - DO THIS FIRST Oct 12, 2023
@seeker25
Copy link
Collaborator

seeker25 commented Oct 13, 2023

https://github.com/babel/babel/blob/master/lerna.json
https://github.com/babel/babel/blob/6.x/lerna.json
https://github.com/babel/babel/blob/next-8-dev/lerna.json

Looks possible to me, just don't overlap when publishing version numbers

@severinbeauvais
Copy link
Collaborator Author

Great example! Thanks for that.

So, as part of THIS ticket, I propose that we create a Vue3 feature branch so we can work on these shared components separately. When a component is updated to Vue3, we will increase its major version number. The previous versions can still be updated in main branch.

Any thoughts on when we can replace main branch with the Vue3 branch (or merge into)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team techdebt
Projects
None yet
Development

No branches or pull requests

5 participants