Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25579 - Remove Save/Resume Button for NoW filing #715

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

ArwenQin
Copy link
Collaborator

Issue #: /bcgov/entity#25579

Description of changes:

  • Remove the "Save" and "Save and Resume Later" button in NoW filing
  • Add a warning when click Cancel button and there are changes made
  • Remove unneeded codes for save/load draft

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin ArwenQin self-assigned this Jan 30, 2025
@ArwenQin
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-715-afqkyzy0.web.app

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Jan 30, 2025

@ArwenQin
Copy link
Collaborator Author

Since there will be no NoW drafts now, for Business Dashboard: shall we create a new ticket to remove the codes handling FilingTypes.NOTICE_OF_WITHDRAWAL in To Do List?
(It doesn't hurt leaving the codes there, just wondering if it's more clear)

@severinbeauvais
Copy link
Collaborator

Since there will be no NoW drafts now, for Business Dashboard: shall we create a new ticket to remove the codes handling FilingTypes.NOTICE_OF_WITHDRAWAL in To Do List? (It doesn't hurt leaving the codes there, just wondering if it's more clear)

I assume there's fallback code to handle "unknown" items in the To Do list? If so then I agree with deleting specific NOW code in the To Do list (cleanup).

Copy link
Collaborator

@meawong meawong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@eason-pan-bc eason-pan-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you !

@ArwenQin ArwenQin merged commit 3608c70 into bcgov:main Jan 31, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants