Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25095 process header date #607

Merged
merged 4 commits into from
Jan 3, 2025
Merged

25095 process header date #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82b38f6
process header date
Rajandeep98 Jan 2, 2025
c426cbc
updated pckg , correction getter
Rajandeep98 Jan 3, 2025
8dacbdb
lint fixes
Rajandeep98 Jan 3, 2025
14deab3
replacing pckg file
Rajandeep98 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.11.12",
"version": "4.11.13",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/store-interfaces/state-interfaces/correction-information-interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ContactPointIF, NaicsIF, NameRequestIF, SpecialResolutionIF } from '@bc
export interface CorrectionInformationIF extends CoopAlterationIF, SpecialResolutionIF {
comment: string // max 4096 characters
correctedFilingId: number
correctedFilingDate?: string // API format
correctedFilingDate?: string // filing date is in YYYY-MM-DD format
correctedFilingType: FilingTypes
type: CorrectionErrorTypes
legalType?: CorpTypeCd
Expand Down
11 changes: 5 additions & 6 deletions src/mixins/filing-template-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export default class FilingTemplateMixin extends DateMixin {
},
correctedFilingId: this.getCorrectedFilingId,
correctedFilingType: this.getCorrectedFilingType,
correctedFilingDate: this.correctedFilingDate,
correctedFilingDate: this.getCorrectedFilingDate,
comment: `${this.defaultCorrectionDetailComment}\n${this.getDetailComment}`,
contactPoint: this.getContactPoint,
nameRequest: {
Expand Down Expand Up @@ -1455,15 +1455,14 @@ export default class FilingTemplateMixin extends DateMixin {
/** The default (hard-coded first line) correction detail comment. */
public get defaultCorrectionDetailComment (): string {
const correctedFilingName = FilingTypeToName(this.getCorrectedFilingType)
return `Correction for ${correctedFilingName} filed on ${this.correctedFilingDate}`
return `Correction for ${correctedFilingName} filed on ${this.getCorrectedFilingDate}`
}

// FUTURE: probably don't need this becayse Corrected Filing Date is already YYYY-MM-DD
/** The corrected filing date as YYYY-MM-DD. */
private get correctedFilingDate (): string {
const date = this.apiToDate(this.getCorrectedFilingDate)
return this.dateToYyyyMmDd(date)
}
// private get correctedFilingDate (): string {
// return this.getCorrectedFilingDate
// }

/** The Contact Point object. */
private get getContactPoint (): ContactPointIF {
Expand Down
Loading