Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25095 process header date #607

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Conversation

Rajandeep98
Copy link
Collaborator

@Rajandeep98 Rajandeep98 commented Jan 2, 2025

*Issue #:#25095

Description of changes:

header date update while filing a correction

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@Rajandeep98
Copy link
Collaborator Author

/gcbrun

@Rajandeep98 Rajandeep98 self-assigned this Jan 2, 2025
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-607-fagvyacc.web.app

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please don't forget to update the package.json version and do an npm i

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted obsolete comment

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jan 2, 2025

deleted obsolete comment

pnpm-lock.yaml Outdated Show resolved Hide resolved
@Rajandeep98
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-607-fagvyacc.web.app

@severinbeauvais
Copy link
Collaborator

I verified this by creating a correction, editing it at the preview URL, filing it, and looking at the outputs. LGTM.

@Rajandeep98 Rajandeep98 merged commit 7ece621 into bcgov:main Jan 3, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants