Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Fee Reciept and File Pay button for minimal changes in the f… #605

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

Rajandeep98
Copy link
Collaborator

@Rajandeep98 Rajandeep98 commented Dec 23, 2024

…iling

Issue #24945: /bcgov/entity#24945

Description of changes:

  • enable file and pay button for details
  • enable fee summary in all cases

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@Rajandeep98
Copy link
Collaborator Author

/gcbrun

@Rajandeep98 Rajandeep98 self-assigned this Dec 23, 2024
@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Dec 23, 2024

Temporary Url for review: https://business-edit-dev--pr-605-ksxvmv8i.web.app

SB says, try these businesses:

  • FM110404
  • CP1002792
  • BC0884495

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested a no-change correction for the 3 test businesses and all showed the fee summary and I was able to file them after entering just a detail comment 👍

Also, it looks like the Filer processed the corrections 👍

The application output still needs to be updated (separate ticket).

Pre-approved as I trust you to make the small changes above.

Copy link
Collaborator

@ArwenQin ArwenQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Rajandeep98
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-605-ksxvmv8i.web.app

@Rajandeep98 Rajandeep98 merged commit fa38f6e into bcgov:main Dec 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants