Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit UI: allow correction with only detail comment #24945

Closed
4 tasks
severinbeauvais opened this issue Dec 13, 2024 · 6 comments
Closed
4 tasks

Edit UI: allow correction with only detail comment #24945

severinbeauvais opened this issue Dec 13, 2024 · 6 comments
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Dec 13, 2024

  • allow file and pay with only detail comment entered
  • show fee summary even when no data has been changed
  • verify save and resume later
  • try this and verify that:
    • Legal API accepts the correction filing
    • Filer processes it successfully (it should actually change nothing since it's an empty correction)
    • if not then create more tickets
@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Dec 13, 2024
@Rajandeep98 Rajandeep98 self-assigned this Dec 21, 2024
@OlgaPotiagalova
Copy link
Collaborator

@riyazuddinsyed and @vishnup0422 , could you please prioritize this ticket for your testing as we will try to reuse this approach for ledger correction for BEN company. Thank you.

@riyazuddinsyed
Copy link
Collaborator

I was able to file Detail as a correcting to only Limited Company and apart from that, no other Business Type is working just by adding Detail.Moving the ticket back.

@severinbeauvais
Copy link
Collaborator Author

The code for this change is in Edit UI v4.11.13.

In Test environment, you have Edit UI v4.11.12.

Please test again in Dev or wait for the change to be deployed to Test.

(PS I have tested BC, BEN, CC and ULC in Dev.)

@riyazuddinsyed
Copy link
Collaborator

riyazuddinsyed commented Dec 31, 2024

@severinbeauvais I have been testing in dev env and this BC0883580 Benefit company for ex in Dev, I cannot file a correction with only detail.
BC0883771 this CCC
C9900759 this ULC

@severinbeauvais
Copy link
Collaborator Author

Ok, I'll try it again tomorrow.

@severinbeauvais
Copy link
Collaborator Author

@riyazuddinsyed , I was able to file both "empty" corrections for the companies you listed above.

Note that you selected "client correction" in both cases, so you also needed to fill in the Completing Party. When I did that, I was able to file both corrections with only Detail (and also Certify).

I did notice that the File and Pay button was enabled even when the Completing Party is incomplete, and I think that should be fixed. @Rajandeep98 , can you please have a quick look at this, and let me know if you can fix that in this ticket or whether a new ticket is needed? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.
Projects
None yet
Development

No branches or pull requests

4 participants