24678 Updated NR error dialog #603
Conversation
|
/gcbrun |
0bc58e0 to
c8ce35e
Compare
- removed wrong-looking page alert icon - added a base class - refactored NR error check - updated NR error dialog title - refactored NR error dialog text (now 3 cases with sub-cases) including new error text - added CHG and CNV NRs as valid options for Alteration filings - removed CNV NR as a valid option for corp Correction filings - added CHG NR as a valid option for Limited Restoration to Full filings - added CHG NR as a valid option for Special Resolution filings - updated unit tests
c8ce35e to
a78d1e5
Compare
ab6d126 to
7781431
Compare
| @@ -100,7 +100,8 @@ | |||
| v-if="bannerText" | |||
| tile | |||
| dense | |||
| type="warning" | |||
| class="mb-0" | |||
| color="warning" | |||
There was a problem hiding this comment.
Before (warning icon is mostly hidden, incorrect whitespace below alert):
After:
| @@ -55,7 +55,8 @@ const vuetify = new Vuetify({ | |||
| error: '#d3272c', // same as $app-red | |||
| success: '#1a9031', // same as $app-green | |||
| gray7: '#495057', // same as $gray7 | |||
| gray9: '#212529' // Same as $gray9 | |||
| gray9: '#212529', // Same as $gray9 | |||
| warning: '#fb8c00' | |||
There was a problem hiding this comment.
This is the hex code for a v-alert of type "warning".
| @@ -23,6 +24,10 @@ export const AlterationResourceBc: ResourceIF = { | |||
| CorrectNameOptions.CORRECT_NEW_NR, | |||
| CorrectNameOptions.CORRECT_NAME_TO_NUMBER | |||
| ], | |||
| nameRequestTypes: [ | |||
| NrRequestActionCodes.CHANGE_NAME, | |||
| NrRequestActionCodes.CONVERSION | |||
There was a problem hiding this comment.
Either of these NR types can be used for an alteration.
Ditto below, etc.
| @@ -25,8 +25,7 @@ export const CorrectionResourceBc: ResourceIF = { | |||
| subtitle: null // not used | |||
| }, | |||
| nameRequestTypes: [ | |||
| NrRequestActionCodes.CHANGE_NAME, | |||
| NrRequestActionCodes.CONVERSION | |||
There was a problem hiding this comment.
A conversion NR is not valid for a correction (since we do not change business type in a correction).
| @@ -27,6 +27,7 @@ export const RestorationResourceBc: ResourceIF = { | |||
| subtitle: null // not used | |||
| }, | |||
| nameRequestTypes: [ | |||
| NrRequestActionCodes.CHANGE_NAME, | |||
| NrRequestActionCodes.RESTORE | |||
There was a problem hiding this comment.
If the business is in limited restoration then it's active, and Namerequest UI won't find it in a historical search for a restoration NR. So, this allows the use of a change of name NR for a limited-restored business.
| @@ -23,10 +23,10 @@ export const SpecialResolutionResourceCp: ResourceIF = { | |||
| correctNameOptions: [ | |||
| CorrectNameOptions.CORRECT_NEW_NR | |||
| ], | |||
| typeChangeInfo: 'You cannot change the business type of a Cooperative Association. You must form a new' + | |||
| 'business and dissolve this business once the new business is registered.', | |||
There was a problem hiding this comment.
This was missing a space between "new" and "business".
|
|
||
| nr.request_action_cd = 'CHG' | ||
| expect(vm.isNrInvalid(nr)).toBe(true) | ||
| expect(vm.isNrInvalid(nr)).toBe(false) // valid |
There was a problem hiding this comment.
The Name Request Mixin now allows 3 types of NRs (CNV, CHG, REH). It's the component itself that will check the NR type against the allowed types from the resources (depending on the filing type).
Issue #: bcgov/entity#24678
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).