Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit UI: wrong error when using CNV NR in a correction #24678

Closed
severinbeauvais opened this issue Nov 29, 2024 · 13 comments
Closed

Edit UI: wrong error when using CNV NR in a correction #24678

severinbeauvais opened this issue Nov 29, 2024 · 13 comments
Assignees
@severinbeauvais
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority3

Comments

@severinbeauvais
Copy link
Collaborator

A correction filing allows the use of a NR to correct the Company Name. Normally this would be a NR of type CHG (name change).

However, if you enter a NR of type CNV (conversion aka alteration) then you get the following error dialog. This is the wrong title and message.

image.png

I believe this is low severity, since it correctly blocks the use of the wrong NR type in a correction.
@severinbeauvais severinbeauvais added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Nov 29, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 29, 2024 •
edited
Loading

This can be tested with this correction: https://dev.edit.business.bcregistry.gov.bc.ca/BC0883655/correction/?correction-id=152657&accountid=3040

And this NR: NR 1053586 (ph: 1234)

@severinbeauvais severinbeauvais self-assigned this Dec 2, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Dec 3, 2024 •
edited
Loading

Test Notes

  1. a name change NR should be valid for an Alteration if the business type matches
  2. a name change NR should be valid for a Change of Registration if the business type matches
  3. a name change NR should be valid for a Correction (corp, coop, firm) if the business type matches
  4. a name change NR should be valid for a Conversion to Full Restoration if the business type matches
  5. a name change NR should be valid for a Special Resolution if the business type matches
  6. a conversion NR should be valid for an alteration if the alteration is supported, ie:
    • BC to BC
    • BC to BEN
    • BC to ULC
    • BC to CC
    • BEN to BEN
    • BEN to BC
    • BEN to CC
    • ULC to ULC
    • ULC to BEN
    • ULC to BC
  7. otherwise, display an appropriate error dialog

Test Data

Name Requests

Businesses

See below for screenshots.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Dec 4, 2024 •
edited
Loading

@janisrogers @jacqueline-williams-549 What do you think of this updated text?

Business Type doesn't match

image.png

Wrong type of NR

image.png

@janisrogers
Copy link
Collaborator

The last message doesn't tell them how to move forward. Can we let them know what they need?

@severinbeauvais severinbeauvais mentioned this issue Dec 4, 2024
Merged
@severinbeauvais
Copy link
Collaborator Author

The last message doesn't tell them how to move forward. Can we let them know what they need?

No, because I don't know all possible kinds of filing they're trying to use this Alteration NR for, so I can't tell them what kind of NR to use. (Yesterday we made the assumption that it must be a Correction filing but you know what they say about assumptions.)

@janisrogers
Copy link
Collaborator

Can we tell what filing they are in when the error is triggered?

@severinbeauvais
Copy link
Collaborator Author

Yes, we know what filing they're in.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Dec 4, 2024 •
edited
Loading

deleted obsolete comment

@janisrogers
Copy link
Collaborator

Could we change the text to indicate what type of NR they need (using NR language) for the type of filing they are in?

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Dec 4, 2024 •
edited
Loading

I think so.

Please give me an example of what the dialog body should say. Sample:

This Name Request is for a Restoration.

For this Alteration, you can use only the following Name Request types:
- Alteration
- Change of Name

@janisrogers
Copy link
Collaborator

That looks okay to me.

@severinbeauvais
Copy link
Collaborator Author

I'm still working on this :)

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Dec 5, 2024 •
edited
Loading

Test Results

ULC change of name NR for a ULC correction

image.png

Alteration NR for a ULC correction

image.png

SP NR for a ULC correction

image.png

BC NR for a ULC correction

image.png

CP NR for a ULC correction

image.png

Restoration NR for a ULC correction

image.png

ULC change of name NR for a ULC alteration

image.png

ULC alteration NR for a ULC alteration

image.png

SP NR for a ULC alteration

image.png

BC NR for a ULC alteration

image.png

CP NR for a ULC alteration

image.png

Restoration NR for a ULC alteration

image.png

ULC NR for a BEN alteration

image.png

SP NR for a BEN alteration

image.png

BC NR for a BEN alteration

image.png

CP NR for a BEN alteration

image.png

Restoration NR for a BEN alteration

image.png

SP change of name NR for a SP change of registration

image.png

ULC NR for a SP change of registration

image.png

Alteration NR for a SP change of registration

image.png

BC NR for a SP change of registration

image.png

CP NR for a SP change of registration

image.png

Restoration NR for a SP change of registration

image.png

ULC NR for a BC conversion to full restoration

image.png

Alteration NR for a BC conversion to full restoration

image.png

SP NR for a BC conversion to full restoration

image.png

BC change of name NR for a BC conversion to full restoration

image.png

CP NR for a BC conversion to full restoration

image.png

BC restoration NR for a BC conversion to full restoration

image.png

(Note: there was no check for the correct business id.)

ULC NR for a CP special resolution

image.png

Alteration NR for a CP special resolution

image.png

SP NR for a CP special resolution

image.png

BC NR for a CP special resolution

image.png

CP name change NR for a CP special resolution

image.png

Alteration NR for a CP special resolution

image.png

@severinbeauvais severinbeauvais mentioned this issue Dec 6, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@severinbeauvais severinbeauvais

Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@severinbeauvais @janisrogers @OlgaPotiagalova @jacqueline-williams-549