Quick pass at Swift Modernizing (#256)

Just fixing dead-simple deprecations and warnings I noticed while writing
PR #255, broken out for easy reviewing.

No functionality changes and not comprehensive; just a quick tidy.

src/Tulsi/ConfigEditorWizardViewController.swift

@@ -141,7 +141,7 @@ final class ConfigEditorWizardViewController: NSViewController, NSPageController
     viewController.representedObject = representedObject
 
     // This index is guaranteed to exist due to fixed number of pages we have.
-    let newPageIndex = ConfigEditorWizardViewController.wizardPageIdentifiers.index(of: object as! String)!
+    let newPageIndex = ConfigEditorWizardViewController.wizardPageIdentifiers.firstIndex(of: object as! String)!
     let subview = viewController as? WizardSubviewProtocol
     subview?.presentingWizardViewController = self
     if pageController.selectedIndex < newPageIndex {

src/Tulsi/HeadlessXcodeProjectGenerator.swift

@@ -74,7 +74,7 @@ struct HeadlessXcodeProjectGenerator {
     var config = try loadConfig(configURL, bazelURL: explicitBazelURL)
     config = config.configByAppendingPathFilters(arguments.additionalPathFilters)
     if let project = projectDocument.project {
-      config = config.configByResolvingInheritedSettingsFromProject(project);
+      config = config.configByResolvingInheritedSettingsFromProject(project)
     }
 
     let workspaceRootURL: URL

src/Tulsi/NewGeneratorConfigViewController.swift

@@ -16,7 +16,7 @@ import Cocoa
 
 
 /// Protocol used to inform receiver of a NewGeneratorConfigViewController's exit status.
-protocol NewGeneratorConfigViewControllerDelegate: class {
+protocol NewGeneratorConfigViewControllerDelegate: AnyObject {
   func viewController(_ vc: NewGeneratorConfigViewController,
                       didCompleteWithReason: NewGeneratorConfigViewController.CompletionReason)
 }

src/Tulsi/NewProjectViewController.swift

@@ -16,7 +16,7 @@ import Cocoa
 
 
 /// Protocol used to inform receiver of a NewProjectViewController's exit status.
-protocol NewProjectViewControllerDelegate: class {
+protocol NewProjectViewControllerDelegate: AnyObject {
   func viewController(_ vc: NewProjectViewController,
                       didCompleteWithReason: NewProjectViewController.CompletionReason)
 }

src/Tulsi/OptionsEditorModelProtocol.swift

@@ -17,7 +17,7 @@ import TulsiGenerator
 
 
 /// Provides functionality for accessing and mutating an object capable of storing Tulsi options.
-protocol OptionsEditorModelProtocol: class {
+protocol OptionsEditorModelProtocol: AnyObject {
   /// The name of the project that the model's options are associated with.
   var projectName: String? { get }
 

src/Tulsi/OptionsTargetSelectorController.swift

@@ -28,7 +28,7 @@ class OptionsTargetNode: UISelectableOutlineViewNode {
 }
 
 
-protocol OptionsTargetSelectorControllerDelegate: class {
+protocol OptionsTargetSelectorControllerDelegate: AnyObject {
   /// Invoked when the target selection has been changed.
   func didSelectOptionsTargetNode(_ node: OptionsTargetNode)
 }

src/Tulsi/SplashScreenWindowController.swift

@@ -104,7 +104,7 @@ final class SplashScreenWindowController: NSWindowController, NSTableViewDelegat
         continue
       }
 
-      var components: [String] = url.pathComponents
+      let components: [String] = url.pathComponents
       var i = components.count - 1
       repeat {
         if (components[i] as NSString).pathExtension == projectExtension {
@@ -121,12 +121,12 @@ final class SplashScreenWindowController: NSWindowController, NSTableViewDelegat
         projectURL = NSURL.fileURL(withPathComponents: projectComponents)! as URL
       }
       if (recentDocumentURLs.contains(projectURL)) {
-        continue;
+        continue
       }
-      recentDocumentURLs.insert(projectURL);
+      recentDocumentURLs.insert(projectURL)
 
       let viewController = SplashScreenRecentDocumentViewController()
-      viewController.url = projectURL;
+      viewController.url = projectURL
       recentDocumentViewControllers.append(viewController)
     }
 

src/Tulsi/TulsiGeneratorConfigDocument.swift

@@ -16,7 +16,7 @@ import Cocoa
 import TulsiGenerator
 
 
-protocol TulsiGeneratorConfigDocumentDelegate: class {
+protocol TulsiGeneratorConfigDocumentDelegate: AnyObject {
   /// Called when the TulsiGeneratorConfigDocument is saved successfully with a new name.
   func didNameTulsiGeneratorConfigDocument(_ document: TulsiGeneratorConfigDocument, configName: String)
 

src/Tulsi/TulsiProjectDocument.swift

@@ -166,7 +166,7 @@ final class TulsiProjectDocument: NSDocument,
   }
 
   deinit {
-    NotificationCenter.default.removeObserver(logEventObserver)
+    NotificationCenter.default.removeObserver(logEventObserver!)
   }
 
   func clearMessages() {

src/Tulsi/UIMessage.swift

@@ -16,7 +16,7 @@ import Cocoa
 import TulsiGenerator
 
 /// Defines an object that holds an array of UIMessages.
-protocol MessageLogProtocol: class {
+protocol MessageLogProtocol: AnyObject {
   var messages: [UIMessage] { get }
 }
 

src/Tulsi/UISelectableOutlineViewNode.swift

@@ -15,7 +15,7 @@
 import Cocoa
 
 
-protocol Selectable: class {
+protocol Selectable: AnyObject {
   var selected: Bool { get set }
 }
 

src/TulsiGenerator/PBXProjSerializer.swift

@@ -17,7 +17,7 @@ import Foundation
 let XcodeProjectArchiveVersion = "1"
 
 
-protocol PBXProjSerializable: class {
+protocol PBXProjSerializable: AnyObject {
   func serializeInto(_ serializer: PBXProjFieldSerializer) throws
 }
 

src/TulsiGenerator/PBXTargetGenerator.swift

@@ -53,7 +53,7 @@ struct StubInfoPlistPaths {
 }
 
 /// Defines an object that can populate a PBXProject based on RuleEntry's.
-protocol PBXTargetGeneratorProtocol: class {
+protocol PBXTargetGeneratorProtocol: AnyObject {
   static func getRunTestTargetBuildConfigPrefix() -> String
 
   static func workingDirectoryForPBXGroup(_ group: PBXGroup) -> String

src/TulsiGenerator/XcodeProjectGenerator.swift

@@ -1434,7 +1434,7 @@ final class XcodeProjectGenerator {
         // Only over-write if needed.
         if fileManager.fileExists(atPath: targetURL.path) {
           guard !fileManager.contentsEqual(atPath: sourceURL.path, andPath: targetURL.path) else {
-            continue;
+            continue
           }
           print("Overwriting \(targetURL.path) as its contents changed.")
           try fileManager.removeItem(at: targetURL)