Fix missing dependency #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
Jul 26, 2022
|
We should build this on CI somewhere, probably as an example dep? |
thii
added a commit
to thii/rules_swift
that referenced
this pull request
Jul 27, 2022
Prevents issues with non-hermetic bugs like bazelbuild#865.
|
Looks like it was a non-hermetic bug (it's being built on CI already) #866 |
thii
added a commit
that referenced
this pull request
Jul 27, 2022
Prevents issues with non-hermetic bugs like #865.
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Fixes the following compilation error: ``` external/com_github_apple_swift_nio_transport_services/Sources/NIOTransportServices/NIOTSConnectionChannel.swift:20:8: error: no such module 'NIOTLS' ```
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Prevents issues with non-hermetic bugs like bazelbuild#865.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following compilation error: