Skip to content

Commit

Permalink
Enable sandboxing for swift builds (#866)
Browse files Browse the repository at this point in the history
Prevents issues with non-hermetic bugs like
#865.
  • Loading branch information
thii authored Jul 27, 2022
1 parent 4ab0e56 commit 088096a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ x_defaults:
- "-//examples/xplatform/grpc/..." # TODO: Fix grpc on Linux
windows_common: &windows_common
platform: windows
build_flags:
# Override 'sandboxed' strategy set in .bazelrc because it's not
# available on Windows
- "--strategy=SwiftCompile="
build_targets:
- "//tools/..."

Expand Down
4 changes: 4 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ build --macos_minimum_os=10.15

# Make sure no warnings slip into the C++ tools we vendor
build --features treat_warnings_as_errors

# The default strategy is worker, which has sandboxing disabled by default,
# which can hide issues with non-hermetic bugs.
build --strategy=SwiftCompile=sandboxed

0 comments on commit 088096a

Please sign in to comment.