Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to options capabilities to kotlinc repository #963

Merged
merged 8 commits into from
May 14, 2023
Merged

Move to options capabilities to kotlinc repository #963

merged 8 commits into from
May 14, 2023

Conversation

restingbull
Copy link
Collaborator

@restingbull restingbull commented Apr 21, 2023 •
edited
Loading

  • This simplifies the option resolution for head.
  • Multiple kotlin toolchains can be more simply handled via bzlmod.
  • Options and defaults can be built via reflection (see Generate koltinc options #962 for in progress POC)

This is a branch based on @comius' work in #900, with small cleanups.

@restingbull restingbull changed the title Move to the option strategy presented in https://github.com/bazelbuild/rules_kotlin/pull/900 Move to options capabilities to kotlinc repository Apr 21, 2023
@restingbull restingbull marked this pull request as ready for review April 21, 2023 19:41
@restingbull
Move to the option strategy presented in #900
213f0f7 
This simplifies the option resolution for head.

Multiple kotlin toolchains can be more simply handled via bzlmod.
@restingbull
Fix rebase
d40c99a
@restingbull restingbull force-pushed the restingbull/comius-couple-opts branch from 7e0d422 to d40c99a Compare April 23, 2023 15:05
@restingbull restingbull merged commit f36c3fa into master May 14, 2023
@restingbull restingbull deleted the restingbull/comius-couple-opts branch May 14, 2023 23:09
@restingbull restingbull mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bencodes Bencodes Awaiting requested review from Bencodes Bencodes is a code owner

@nkoroste nkoroste Awaiting requested review from nkoroste nkoroste is a code owner

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@timpeut timpeut Awaiting requested review from timpeut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@restingbull @Bencodes