Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate koltinc options #962

Merged
merged 5 commits into from
May 23, 2023
Merged

Generate koltinc options #962

merged 5 commits into from
May 23, 2023

Conversation

restingbull
Copy link
Collaborator

@restingbull restingbull commented Apr 21, 2023

To generate a new set of flags, run:
bazel run //src/main/kotlin/io/bazel/kotlin/generate:kotlin_release_options

Next steps:

  • move full option generation to the capabilities file.
  • set defaults to match the compiler defaults
  • live update for development once rules_kotlin can be built with the last version of rules_kotlin

@restingbull restingbull changed the base branch from master to restingbull/comius-couple-opts April 21, 2023 19:37
@restingbull restingbull force-pushed the restingbull/comius-couple-opts branch from 7e0d422 to d40c99a Compare April 23, 2023 15:05
@Bencodes Bencodes force-pushed the restingbull/generate-options-poc branch from 274a824 to a6ffbad Compare May 4, 2023 18:06
Base automatically changed from restingbull/comius-couple-opts to master May 14, 2023 23:09
To generate a new set of flags, run:
`bazel run //src/main/kotlin/io/bazel/kotlin/generate:kotlin_release_options`
@restingbull restingbull force-pushed the restingbull/generate-options-poc branch from a6ffbad to 0b51189 Compare May 15, 2023 00:05
@restingbull restingbull changed the title Generate koltinc options POC Generate koltinc options May 15, 2023
@restingbull restingbull requested review from Bencodes and nkoroste May 15, 2023 00:13
@restingbull restingbull marked this pull request as ready for review May 15, 2023 00:13
KOTLIN_OPTS = [
"-P",
"-Werror",
"-X",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs to be filtered out I think.

]
"-api-version",
"-classpath",
"-d",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also needs to be filtered out.

@restingbull
Copy link
Collaborator Author

Cleaned up the flags -- nothing new is being exposed until we generate the option definitions.

@Bencodes Bencodes merged commit 883a27f into master May 23, 2023
@Bencodes Bencodes deleted the restingbull/generate-options-poc branch May 23, 2023 22:39
nkoroste added a commit that referenced this pull request Jul 26, 2023
…idanceKotlin_upstream

* upstream/master: (51 commits)
  Expose ksp_version (#989)
  Bump quick guide to use v1.8 (#987)
  Fail CI if the docs are outdated (#961)
  Rename dev_io_bazel_rules_kotlin -> io_bazel_rules_kotlin (#973)
  update stardoc to 0.5.6 (#986)
  fix readme about kotlinc_opts and javac_opts (#984)
  Update README with KSP support (#983)
  Regenerate the docs (#980)
  Update the README.md with the latest dev override config (#981)
  Remove opts.release.bzl which is no longer being used (#982)
  Remove print warning from kt_download_local_dev_dependencies (#974)
  Avoid creating duplicate android_sdk_repositories (#978)
  Normalize label (#968)
  Generate koltinc options (#962)
  Restore neverlink on compiler. (#977)
  Use the mnemonic for worker keys (#976)
  Update KtLint to 0.49.1 (#970)
  Add support for -Xuse-fir-lt (#972)
  Support -Xenable-incremental-compilation (#971)
  Update to Kotlin 1.8.21 (#969)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants