-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
Can users have both args defined in the BUILD fuel and pass in args in the cli? |
Yes, in the e2e tests I added both verification for use of args in the attrs defined in the BUILD file as well as one for use of bazel run -- |
You gonna rebase? Ping me when the tests are happy and I will merge ;) |
alright, that was fun to debug. Tests are passing now, ptal. |
Harping on this, but do we want to squash the commits on merging? I like to keep master clean so we can easily back out a PR. I prefer when the PR owner squashed there commits into units of work. |
its set up for squash and merge, so it'll be 1 commit only |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Pass through arguments * Add e2e-test based on #224
Trying this PR to replace all other PRs discussed in #209.
With this PR:
bazel run <target> -- <extra args>
Hope this satisfies everyone's needs.
fyi @chrislovecnm @Globegitter @omadawn