Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Add command specific arguments #207

Closed
wants to merge 31 commits into from

Conversation

Globegitter
Copy link
Contributor

@Globegitter Globegitter commented Oct 26, 2018

This is instead of #174 to be able to pass command specific arguments directly from the cli, e.g. bazel run :target.apply -- --dry-run. This would fix #145 and could complement ##198 to be able to specify both kubectl global and command specific flags. Hopefully this will also fix the tests.

Let me know what you think about this approach.

omadawn and others added 30 commits July 30, 2018 09:31
Added documentation for new flag.
Merge branch 'addArbitraryCommands' of https://github.com/omadawn/rules_k8s into addArbitraryCommands
Merge branch 'addArbitraryCommands' of https://github.com/omadawn/rules_k8s into addArbitraryCommands
Merge branch 'addArbitraryCommands' of https://github.com/omadawn/rules_k8s into addArbitraryCommands
…to a test that was supposed to fail for other reasons.
…to a test that was supposed to fail for other reasons.
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Globegitter
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@k8s-ci-robot
Copy link

Hi @Globegitter. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrislovecnm
Copy link
Contributor

Appreciate the PR, but IMO we cannot merge all of these commits 😞

The commits need to be rebased into chunks of reasonable work that can be backed out of master.

IMO all these commits are going to cause a mess in master.

Please rebase or redo the PR.

Happy to have this functionality, but do we need to use $@??

@fejta
Copy link
Contributor

fejta commented Oct 26, 2018

all these commits are going to cause a mess in master

Won't clicking "squash and merge" make github put them into a single commit? Not sure if we need/want to follow the kubernetes org strategy of allowing PRs with multiple commits (and therefore requiring manual commit management).

Please rebase

The way to do this is to do something like git rebase -i HEAD~31 and then change all the pick lines except the first one to f (for fixup, which drops the commit message) or s (for squash, which adds the commit message).

Alternatively you could do git reset HEAD~31 && git add -A && git commit -m "blah blah blah"

@chrislovecnm
Copy link
Contributor

@fejta this commit will not squash or merge cleanly in a GH submit. I tried to rebase it, not fun.

@nlopezgi
Copy link
Contributor

Closing this with #224 proposed as a solution to the required use case. Please comment in #209 if you still feel we need to keep this open for some reason.

@nlopezgi nlopezgi closed this Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dry run option
7 participants