-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
Added documentation for new flag.
…es_k8s into addArbitraryCommands
Merge branch 'addArbitraryCommands' of https://github.com/omadawn/rules_k8s into addArbitraryCommands
Merge branch 'addArbitraryCommands' of https://github.com/omadawn/rules_k8s into addArbitraryCommands
Merge branch 'addArbitraryCommands' of https://github.com/omadawn/rules_k8s into addArbitraryCommands
…es_k8s into addArbitraryCommands
…to a test that was supposed to fail for other reasons.
…to a test that was supposed to fail for other reasons.
…es_k8s into addArbitraryCommands
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Globegitter If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Hi @Globegitter. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Appreciate the PR, but IMO we cannot merge all of these commits 😞 The commits need to be rebased into chunks of reasonable work that can be backed out of master. IMO all these commits are going to cause a mess in master. Please rebase or redo the PR. Happy to have this functionality, but do we need to use $@?? |
Won't clicking "squash and merge" make github put them into a single commit? Not sure if we need/want to follow the kubernetes org strategy of allowing PRs with multiple commits (and therefore requiring manual commit management).
The way to do this is to do something like Alternatively you could do |
@fejta this commit will not squash or merge cleanly in a GH submit. I tried to rebase it, not fun. |
This is instead of #174 to be able to pass command specific arguments directly from the cli, e.g.
bazel run :target.apply -- --dry-run
. This would fix #145 and could complement ##198 to be able to specify both kubectl global and command specific flags. Hopefully this will also fix the tests.Let me know what you think about this approach.