Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Refresh iOS tutorial #2314

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

BalestraPatrick
Copy link
Member

Recently, the ios-app project living in bazelbuild/examples was removed. This PR contains a few improvements:

  • I updated our tutorial that shows how to create create a simple iOS app that builds with Bazel not to rely or point to the non-existing project.
  • We now provide all the source code (one Swift file and one Info.plist) to generate a basic sample iOS app in this tutorial.
  • The source code is now Swift instead of Objective-C.
  • Simplified many sentences and commands, along with a few bug fixes required due to breaking changes in rules_xcodeproj (it now requires a @bazel_features explicit dependency).

I think it would be a good idea to move the tutorial to use bzlmod once Bazel 7 ships. For now, we can continue using the WORKSPACE for ease of compatibility with the default Bazel 6 behavior.

Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta comment, @mattrobmattrob has a wonderful template for iOS apps: https://github.com/mattrobmattrob/bazel-ios-swiftui-template. I wonder if we can leverage it in any way (maybe just mentioning it)?

doc/tutorials/ios-app.md Outdated Show resolved Hide resolved
doc/tutorials/ios-app.md Show resolved Hide resolved
doc/tutorials/ios-app.md Outdated Show resolved Hide resolved
doc/tutorials/ios-app.md Outdated Show resolved Hide resolved
doc/tutorials/ios-app.md Outdated Show resolved Hide resolved
doc/tutorials/ios-app.md Show resolved Hide resolved
doc/tutorials/ios-app.md Outdated Show resolved Hide resolved
doc/tutorials/ios-app.md Outdated Show resolved Hide resolved
doc/tutorials/ios-app.md Show resolved Hide resolved
doc/tutorials/ios-app.md Outdated Show resolved Hide resolved
@BalestraPatrick
Copy link
Member Author

@brentleyjones @mattrobmattrob I wasn't aware of that! Awesome resource, added a note about it.

@BalestraPatrick BalestraPatrick merged commit c96c486 into bazelbuild:master Nov 2, 2023
1 check passed
@BalestraPatrick BalestraPatrick deleted the refresh-tutorial branch November 2, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants