Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete stale tutorial content #331

Merged
merged 1 commit into from
Oct 16, 2023
Merged

chore: delete stale tutorial content #331

merged 1 commit into from
Oct 16, 2023

Conversation

alexeagle
Copy link
Collaborator

  1. This contains an iOS app, but the main iOS tutorial linked from https://bazel.build/start/ios-app lives elsewhere
  2. It shows rules_appengine, but that repo appears to have only minimal maintenance for broken flags. Latest comment from a maintainer is 'not being actively maintained' Support for python 3 google sdk rules_appengine#128 (comment)
  3. bazelbuild/codelabs was archived, but there are active community forks at https://github.com/engflow/codelabs and https://github.com/aspect-build/codelabs which have fresher content than this tutorials folder.
  4. No one has touched tutorial/android in four years.

1. This contains an iOS app, but the main iOS tutorial linked from https://bazel.build/start/ios-app lives elsewhere
2. It shows rules_appengine, but that repo appears to have only minimal maintenance for broken flags. Latest comment from a maintainer is 'not being actively maintained' bazelbuild/rules_appengine#128 (comment)
3. bazelbuild/codelabs was archived, but there are active community forks at https://github.com/engflow/codelabs and https://github.com/aspect-build/codelabs which have fresher content than this tutorials folder.
4. No one has touched tutorial/android in four years.
@BalestraPatrick
Copy link
Member

From rules_apple's side, we're okay with removing this since we already have a version of this tutorial which we maintain in rules_apple: https://github.com/bazelbuild/rules_apple/blob/master/doc/tutorials/ios-app.md

@gregestren
Copy link
Collaborator

Re: Android, note https://bazel.build/start/android-app refers to this repo. Particularly examples/android/tutorial.

https://github.com/bazelbuild/examples/tree/main/android/tutorial is different than https://github.com/bazelbuild/examples/tree/main/tutorial/android ?

This looks reasonable to me but paging @ahumesky .

@alexeagle
Copy link
Collaborator Author

Correct, /android/tutorial should remain, /tutorial/android looks like dead code.

@alexeagle
Copy link
Collaborator Author

ping @gregestren could you ask Alex to look? I don't think he has setup notifications from GitHub or doesn't notice them.

@alexeagle
Copy link
Collaborator Author

ping @meisterT

@alexeagle alexeagle enabled auto-merge (squash) October 16, 2023 18:45
@alexeagle alexeagle merged commit 9e29416 into main Oct 16, 2023
@alexeagle alexeagle deleted the rm_tutorials branch October 16, 2023 18:52
@ahumesky
Copy link
Collaborator

ahumesky commented Oct 16, 2023

Looks fine to remove redundant tutorials/samples/examples. Pretty confusing anyway to have both android/tutorial and tutorial/android

BalestraPatrick added a commit to bazelbuild/rules_apple that referenced this pull request Nov 2, 2023
[Recently](bazelbuild/examples#331), the
`ios-app` project living in
[bazelbuild/examples](https://github.com/bazelbuild/examples) was
removed. This PR contains a few improvements:
- I updated our tutorial that shows how to create create a simple iOS
app that builds with Bazel not to rely or point to the non-existing
project.
- We now provide all the source code (one Swift file and one
`Info.plist`) to generate a basic sample iOS app in this tutorial.
- The source code is now Swift instead of Objective-C.
- Simplified many sentences and commands, along with a few bug fixes
required due to breaking changes in `rules_xcodeproj` (it now requires a
`@bazel_features` explicit dependency).

I think it would be a good idea to move the tutorial to use bzlmod once
Bazel 7 ships. For now, we can continue using the `WORKSPACE` for ease
of compatibility with the default Bazel 6 behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants