Make Bazelisk's cache writable when using sandboxing. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runing Bazelisk from within an integration test on Linux or MacOS would fail if sandboxing was enabled since Bazelisk wasn't allowed to write to its cache directory. This commit adds a test flag that fixes this problem. No action is needed on Windows since there is no sandboxing.
philwo
approved these changes
Feb 25, 2019
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Feb 25, 2019
--sandbox_writable_path actually requires the path to exist, which means we cannot add this flag unconditionally.
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Feb 25, 2019
--sandbox_writable_path actually requires the path to exist, which means we cannot add this flag unconditionally.
Merged
fweikert
added a commit
that referenced
this pull request
Feb 25, 2019
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Feb 26, 2019
We have replaced Bazel with Bazelisk on all CI workers. As a consequence, calling "bazel" from PATH will actually invoke Bazelisk, which in turn downloads the requested version of Bazel into a cache directory and then executes it. This caused a problem when an integration test invoked Bazel from PATH (aka Bazelisk) while running inside a sandbox: The sandbox blocked access to the cache directory, thus failing the test. bazelbuild#497 tried to address this problem by whitelisting the cache directory via the --sandbox_writable_path flag. However, this flag requires the given path to exist, which was not the case when tests were running a Bazel binary from their runfiles instead of Bazelisk. Since we cannot easily detect whether a test invokes Bazelisk or another Bazel binary, we're working around this problem by creating the Bazelisk cache directory before running any tests. Fixes bazelbuild#498.
fweikert
added a commit
that referenced
this pull request
Feb 26, 2019
* Explicitly create Bazelisk's cache directory. We have replaced Bazel with Bazelisk on all CI workers. As a consequence, calling "bazel" from PATH will actually invoke Bazelisk, which in turn downloads the requested version of Bazel into a cache directory and then executes it. This caused a problem when an integration test invoked Bazel from PATH (aka Bazelisk) while running inside a sandbox: The sandbox blocked access to the cache directory, thus failing the test. #497 tried to address this problem by whitelisting the cache directory via the --sandbox_writable_path flag. However, this flag requires the given path to exist, which was not the case when tests were running a Bazel binary from their runfiles instead of Bazelisk. Since we cannot easily detect whether a test invokes Bazelisk or another Bazel binary, we're working around this problem by creating the Bazelisk cache directory before running any tests. Fixes #498.
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
Runing Bazelisk from within an integration test on Linux or MacOS would fail if sandboxing was enabled since Bazelisk wasn't allowed to write to its cache directory. This commit adds a test flag that fixes this problem. No action is needed on Windows since there is no sandboxing.
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
--sandbox_writable_path actually requires the path to exist, which means we cannot add this flag unconditionally.
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
* Explicitly create Bazelisk's cache directory. We have replaced Bazel with Bazelisk on all CI workers. As a consequence, calling "bazel" from PATH will actually invoke Bazelisk, which in turn downloads the requested version of Bazel into a cache directory and then executes it. This caused a problem when an integration test invoked Bazel from PATH (aka Bazelisk) while running inside a sandbox: The sandbox blocked access to the cache directory, thus failing the test. bazelbuild#497 tried to address this problem by whitelisting the cache directory via the --sandbox_writable_path flag. However, this flag requires the given path to exist, which was not the case when tests were running a Bazel binary from their runfiles instead of Bazelisk. Since we cannot easily detect whether a test invokes Bazelisk or another Bazel binary, we're working around this problem by creating the Bazelisk cache directory before running any tests. Fixes bazelbuild#498.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Bazelisk from within an integration test on Linux or MacOS would
fail if sandboxing was enabled since Bazelisk wasn't allowed to write to
its cache directory.
This commit adds a test flag that fixes this problem. No action is
needed on Windows since there is no sandboxing.
As a consequence, it should fix the Tulsi test that is blocking bazelbuild/bazel#6495