Skip to content

Commit

Permalink
Rollback of #497 (#499)
Browse files Browse the repository at this point in the history
--sandbox_writable_path actually requires the path to exist, which
means we cannot add this flag unconditionally.
  • Loading branch information
fweikert authored Feb 25, 2019
1 parent 5b89033 commit 7cba25e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions buildkite/bazelci.py
Original file line number Diff line number Diff line change
Expand Up @@ -641,8 +641,9 @@ def execute_commands(
if test_env_vars:
test_flags += ["--test_env={}".format(v) for v in test_env_vars]

if not is_windows():
test_flags.append(get_sandbox_flag_for_bazelisk_cache(platform))
# TODO(https://github.com/bazelbuild/continuous-integration/issues/498): figure out when to add the flag.
# if not is_windows():
# test_flags.append(get_sandbox_flag_for_bazelisk_cache(platform))

test_bep_file = os.path.join(tmpdir, "test_bep.json")
try:
Expand Down

0 comments on commit 7cba25e

Please sign in to comment.