Downstream pipeline improvements #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
commented
Nov 8, 2023
| @@ -1170,6 +1170,12 @@ def use_bazelisk_migrate(): | |||
| """ | |||
| return is_trueish(os.environ.get("USE_BAZELISK_MIGRATE")) | |||
|
|
|||
| def is_downstream_pipeline(): | |||
| """ | |||
| Return true if BAZELCI_DOWNSTREAM_PIPELINE is set | |||
There was a problem hiding this comment.
I have manually set BAZELCI_DOWNSTREAM_PIPELINE=true for all downstream pipelines.
fweikert
approved these changes
Nov 9, 2023
This was referenced Nov 13, 2023
meteorcloudy
added a commit
that referenced
this pull request
Nov 13, 2023
Follow up on #1775 to make sure the injected flags take priority by injecting them at the end of `compute_flags`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--lockfile_mode=offfor downstream pipelines so that Enforce lockfile update bazel#20101 won't break Bazel in downstream pipeline.no_bazel_downstreamtag in downstream pipelines, addressing rules_python docs testcases are failing with Bazel@HEAD rules_python#1481 (comment)