-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce lockfile update #20101
Closed
Closed
Enforce lockfile update #20101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Nov 8, 2023
meteorcloudy
force-pushed
the
enforce_lockfile
branch
from
November 8, 2023 11:22
41a032f
to
20c90b8
Compare
github-actions
bot
removed
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Nov 8, 2023
meteorcloudy
added a commit
to meteorcloudy/bazel
that referenced
this pull request
Nov 9, 2023
- Upgraded rules_python to 0.26.0 to include bazelbuild/rules_python#1433 - Updated the lockfile on all supported platforms. - Enable `--lockfile_mode=update` for regular builds (mostly affecting local build) - Enable `--lockfile_mode=error` for CI builds to ensure lockfile is up-to-date. After this change, please make sure to update the lockfile by running `bazel mod deps` whenever you change the MODULE.bazel file or any .bzl file used in it. Closes bazelbuild#20101. PiperOrigin-RevId: 580553351 Change-Id: I54c3298e6c23c8392226e1e32ba203689f334226
meteorcloudy
added a commit
that referenced
this pull request
Nov 9, 2023
- Upgraded rules_python to 0.26.0 to include bazelbuild/rules_python#1433 - Updated the lockfile on all supported platforms. - Enable `--lockfile_mode=update` for regular builds (mostly affecting local build) - Enable `--lockfile_mode=error` for CI builds to ensure lockfile is up-to-date. After this change, please make sure to update the lockfile by running `bazel mod deps` whenever you change the MODULE.bazel file or any .bzl file used in it. Closes #20101. PiperOrigin-RevId: 580553351 Change-Id: I54c3298e6c23c8392226e1e32ba203689f334226
meteorcloudy
added a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Nov 9, 2023
- Set `--lockfile_mode=off` for downstream pipelines so that bazelbuild/bazel#20101 won't break Bazel in downstream pipeline. - Support filterting out build and test targets by `no_bazel_downstream` tag in downstream pipelines, addressing bazelbuild/rules_python#1481 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--lockfile_mode=update
for regular builds (mostly affecting local build)--lockfile_mode=error
for CI builds to ensure lockfile is up-to-date.After this change, please make sure to update the lockfile by running
bazel mod deps
whenever you change the MODULE.bazel file or any .bzl file used in it.