Download native macOS arm64 binary on M1 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
requested changes
May 17, 2022
c2dcfb3 to
2c6c769
Compare
meteorcloudy
reviewed
Jun 1, 2022
| platform := platforms[runtime.GOOS] | ||
| arch := runtime.GOARCH | ||
| if arch == "arm64" { | ||
| platform = platform + "_arm64" |
There was a problem hiding this comment.
We don't have ubuntu1404_arm64 support yet, so this may break Linux ARM64 support. But I'm not sure what happens right now when you run Bazelisk on Linux ARM64, does it fallback to fetch the x64 binary and somehow works through emulation? /cc @fweikert
There was a problem hiding this comment.
Good question - I think we have added too many things over time. We should refactor the entire platform support (with arm64 in mind).
There was a problem hiding this comment.
OK, I tested on a Linux ARM64 machine, downloading a Bazel binary at a certain commit never worked. So this change isn't make anything worse.
meteorcloudy
approved these changes
Jun 15, 2022
| platform := platforms[runtime.GOOS] | ||
| arch := runtime.GOARCH | ||
| if arch == "arm64" { | ||
| platform = platform + "_arm64" |
There was a problem hiding this comment.
OK, I tested on a Linux ARM64 machine, downloading a Bazel binary at a certain commit never worked. So this change isn't make anything worse.
|
@fweikert Can you make a new release for Bazelisk? |
|
Will do |
gcf-merge-on-green bot
referenced
this pull request
in googleapis/gapic-generator-typescript
Jul 22, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@bazel/bazelisk](https://togithub.com/bazelbuild/bazelisk) | [`^1.11.0` -> `^1.12.0`](https://renovatebot.com/diffs/npm/@bazel%2fbazelisk/1.11.0/1.12.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bazelbuild/bazelisk</summary> ### [`v1.12.0`](https://togithub.com/bazelbuild/bazelisk/releases/tag/v1.12.0) [Compare Source](https://togithub.com/bazelbuild/bazelisk/compare/v1.11.0...v1.12.0) This release brings new features and fixes to both versions of Bazelisk: Go: - Added support for basic HTTP authentication via a .netrc file ([https://github.com/bazelbuild/bazelisk/pull/292](https://togithub.com/bazelbuild/bazelisk/pull/292)) - Improved and fixed Apple Silicon support ([https://github.com/bazelbuild/bazelisk/pull/299](https://togithub.com/bazelbuild/bazelisk/pull/299), [https://github.com/bazelbuild/bazelisk/pull/303](https://togithub.com/bazelbuild/bazelisk/pull/303)) - Rolling releases are now fetched from GCS instead of GitHub ([https://github.com/bazelbuild/bazelisk/pull/319](https://togithub.com/bazelbuild/bazelisk/pull/319)) Python: - Added support for Apple Silicon ([https://github.com/bazelbuild/bazelisk/pull/272](https://togithub.com/bazelbuild/bazelisk/pull/272)) - Implemented verification of downloaded Bazel binaries ([https://github.com/bazelbuild/bazelisk/pull/295](https://togithub.com/bazelbuild/bazelisk/pull/295)) We'd like to thank our contributors [@​chenrui333](https://togithub.com/chenrui333), [@​codeman9](https://togithub.com/codeman9), [@​cpsauer](https://togithub.com/cpsauer), [@​keith](https://togithub.com/keith), [@​linzhp](https://togithub.com/linzhp), [@​Warchant](https://togithub.com/Warchant) and [@​xinnjie](https://togithub.com/xinnjie)! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-typescript). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjIuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEyMi4xIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using macOS on M1 and downloading a commit or any keyword that resolves to a commit (e.g.,
last_green)bazeliskwas downloading from the url:https://storage.googleapis.com/bazel-builds/artifacts/macos/[commit]/bazel.This PR changes the url to be of the form:
https://storage.googleapis.com/bazel-builds/artifacts/macos_arm64/[commit]/bazel.Also, to get tests to now pass on M1,
test.shhas been updated to insert the arch determined fromuname -mfor the versions that supportarm64.See: bazelbuild/continuous-integration#1338