-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch arm64 version when using USE_BAZEL_VERSION=$commit #317
Comments
/cc @fweikert |
I don't have an M1 machine to test, but shouldn't line 35 handle this problem? It's also possible that DarwinFallback() cannot handle commits (just a theory). |
Yeah, I think line 35 only handles release versions ( |
See also #303 |
Just got bitten by this bug when our CI attempted building TensorFlow overnight for AARCH64 after an update to pick a commit hash for the bazel version. |
…ary`. `dynamic_deps` is not used. PiperOrigin-RevId: 465441376
What is the status of this issue? TensorFlow supports ARM64. If |
are you using the latest bazelisk release? |
@keith We were using 1.11.0. I just tried it with 1.12.0 and get a different error now, it fails with a 404. So assuming the path now attempted to be downloaded by bazelisk is correct, then maybe this is now a bazel problem in that the artifacts are not being created. |
This seems now to be dependent on bazelbuild/continuous-integration#1402 and then having the download block removed that was introduced with #346 and #347 |
Currently even the arm64 version of Bazelisk fetches x86_64 version of Bazel binaries when fetching from a commit hash.
bazelisk/platforms/platforms.go
Line 11 in 9102523
macos_arm64
andwindows_arm64
.Although, we currently only publish arm64 Bazel binaries for macOS and Windows, not Linux ...
The text was updated successfully, but these errors were encountered: