Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch arm64 version when using USE_BAZEL_VERSION=$commit #317

Closed
meteorcloudy opened this issue May 13, 2022 · 10 comments · Fixed by #604
Closed

Fetch arm64 version when using USE_BAZEL_VERSION=$commit #317

meteorcloudy opened this issue May 13, 2022 · 10 comments · Fixed by #604
Labels
P2 We'll consider working on this in future. (Assignee optional) type: feature request New feature or request

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented May 13, 2022

Currently even the arm64 version of Bazelisk fetches x86_64 version of Bazel binaries when fetching from a commit hash.

var platforms = map[string]string{"darwin": "macos", "linux": "ubuntu1404", "windows": "windows"}
needs to be updated to include macos_arm64 and windows_arm64.

Although, we currently only publish arm64 Bazel binaries for macOS and Windows, not Linux ...

@meteorcloudy
Copy link
Member Author

/cc @fweikert

@meteorcloudy
Copy link
Member Author

@Wyverald

@fweikert
Copy link
Member

fweikert commented May 13, 2022

I don't have an M1 machine to test, but shouldn't line 35 handle this problem? It's also possible that DarwinFallback() cannot handle commits (just a theory).

@meteorcloudy
Copy link
Member Author

Yeah, I think line 35 only handles release versions (v.LessThan(armSupportVer))

@keith
Copy link
Member

keith commented May 17, 2022

See also #303

@elfringham
Copy link

Just got bitten by this bug when our CI attempted building TensorFlow overnight for AARCH64 after an update to pick a commit hash for the bazel version.
https://ci.linaro.org/view/All/job/ldcg-python-manylinux-tensorflow-onednn-nightly/140/console

elfringham referenced this issue in tensorflow/tensorflow Aug 5, 2022
…ary`.

`dynamic_deps` is not used.

PiperOrigin-RevId: 465441376
@learning-to-play
Copy link

What is the status of this issue? TensorFlow supports ARM64. If USE_BAZEL_VERSION=$commit doesn't work on ARM64, it practically prevents TensorFlow from using this feature.

@keith
Copy link
Member

keith commented Aug 5, 2022

are you using the latest bazelisk release?

@elfringham
Copy link

@keith We were using 1.11.0. I just tried it with 1.12.0 and get a different error now, it fails with a 404. So assuming the path now attempted to be downloaded by bazelisk is correct, then maybe this is now a bazel problem in that the artifacts are not being created.
bazel --version 2022/08/06 09:47:13 Using unreleased version at commit f440f8ec3f63e5d663e1f9d9614f05a39422102a 2022/08/06 09:47:13 Downloading https://storage.googleapis.com/bazel-builds/artifacts/ubuntu1404_arm64/f440f8ec3f63e5d663e1f9d9614f05a39422102a/bazel... 2022/08/06 09:47:13 could not download Bazel: HTTP GET https://storage.googleapis.com/bazel-builds/artifacts/ubuntu1404_arm64/f440f8ec3f63e5d663e1f9d9614f05a39422102a/bazel failed with error 404

@elfringham
Copy link

This seems now to be dependent on bazelbuild/continuous-integration#1402 and then having the download block removed that was introduced with #346 and #347

@fweikert fweikert added type: feature request New feature or request P2 We'll consider working on this in future. (Assignee optional) labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants