Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make http_archive honor $HOME/.netrc" #9341

Closed
wants to merge 1 commit into from

Conversation

katre
Copy link
Member

@katre katre commented Sep 5, 2019

This reverts commit c26e339.

Work on #9327.

@katre katre requested review from dslomov and aehlig September 5, 2019 21:10
@katre
Copy link
Member Author

katre commented Sep 5, 2019

This attempts to mitigate #9327 so that 0.29.1 (#9293) can be released. Once that is done the code can be restored and fixed.

@katre
Copy link
Member Author

katre commented Sep 5, 2019

I cannot reproduce the actual issue, can @keith or @davido please verify this fixes the problem?

@keith
Copy link
Member

keith commented Sep 5, 2019

I can confirm this fixes the issue for me

@davido
Copy link
Contributor

davido commented Sep 6, 2019

I can confirm, that after applying this revert, the line in ~/.netrc:

machine github.com login foo password bar

is ignored, and bazel-dev build headless in gerrit just works.

@katre
Copy link
Member Author

katre commented Sep 6, 2019

Dropping this PR since the issue was fixed separately.

@katre katre closed this Sep 6, 2019
@katre katre deleted the i9327-revert-netrc branch September 6, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants