Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.29.1 - August 2019 (stable) #9293

Closed
katre opened this issue Aug 30, 2019 · 21 comments
Closed

Release 0.29.1 - August 2019 (stable) #9293

katre opened this issue Aug 30, 2019 · 21 comments
Assignees
Labels

Comments

@katre
Copy link
Member

katre commented Aug 30, 2019

A patch release is needed after 0.29.0 (#8572) to address the following issues:

@hlopko
Copy link
Member

hlopko commented Aug 30, 2019

Can we consider a fix for #9296 to be cherrypicked into 0.29.1?

@katre
Copy link
Member Author

katre commented Aug 30, 2019

Yes, I think #9296 is valid.

@jmillikin-stripe
Copy link
Contributor

jmillikin-stripe commented Aug 30, 2019

Filed #9299 for the git_repository regression from v0.27 -> v0.28

@katre
Copy link
Member Author

katre commented Aug 30, 2019

@jmillikin-stripe Thanks!

@katre
Copy link
Member Author

katre commented Aug 30, 2019

Since the fix for #9296 isn't ready, and at this point in the day, before a US holiday weekend, I am going to wait until Tuesday (Sept 3) to cut the first RC for 0.29.1.

@katre
Copy link
Member Author

katre commented Sep 3, 2019

Planning to cut RC1 today. Assuming everything works, we can release on Thursday.

@katre
Copy link
Member Author

katre commented Sep 3, 2019

Release command:

$ ./scripts/release/release.sh create --force_rc=1 0.29.1 0.29.0 2c046486f5febb9e475a5589b59abae77f14245e 9e1d65a1fcebff7169a63acad95c7b44302b89c4 8b0bfaf6716327ca6b60692704e3d57766f7ab1f

@katre
Copy link
Member Author

katre commented Sep 3, 2019

@katre
Copy link
Member Author

katre commented Sep 3, 2019

Downstream tests all pass (after several retries).

@keith
Copy link
Member

keith commented Sep 4, 2019

FYI it seems like a new feature in 0.29.0 broke github archive downloads in some cases #9327 I'm not sure if this warrants a revert or not

@buchgr
Copy link
Contributor

buchgr commented Sep 5, 2019

@katre

An important internal project found a serious bug in remote execution where output files would sometimes not get deleted between builds. In this particular instance we found this to lead to zombie test results. That is test cases showing up as failed that no longer exist in the codebase. I have fixed this problem in master for different reasons not understanding the impact of this bug.
Please cherry-pick: 5c02b92

@katre
Copy link
Member Author

katre commented Sep 5, 2019

@buchgr Please file a github issue so I can track the reason for the cherrypick.

@katre
Copy link
Member Author

katre commented Sep 5, 2019

There already is an issue: #8385

@dslomov
Copy link
Contributor

dslomov commented Sep 6, 2019

Please cherry-pick a0e3bb2 (fix for #9327)

@katre
Copy link
Member Author

katre commented Sep 6, 2019

Creating RC2:

$ ./scripts/release/release.sh create --force_rc=2 0.29.1 e659f0087740f1802d61bd6d40d6cd99f0e52b3a 5c02b92c45b5422971b3164685d9edb771367a1b a0e3bb207fe2044120a2555a37162ee1f2b17500

@katre
Copy link
Member Author

katre commented Sep 6, 2019

@katre
Copy link
Member Author

katre commented Sep 6, 2019

Downstream tests pass! Assuming no further blockers, I should be able to finalize the release on Tuesday, September 10.

@katre
Copy link
Member Author

katre commented Sep 10, 2019

I am finalizing this release today.

@katre
Copy link
Member Author

katre commented Sep 10, 2019

Release is available at https://github.com/bazelbuild/bazel/releases/tag/0.29.1

@petemounce, @excitoon, and @vbatts, please update your packages.

@vbatts
Copy link

vbatts commented Sep 10, 2019 via email

@petemounce
Copy link
Contributor

Pushed to chocolatey

@katre katre closed this as completed Sep 18, 2019
@dslomov dslomov unpinned this issue Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants