Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bundled gRPC to 1.18.0 and nanopb to 0.3.6 #7368

Closed
wants to merge 2 commits into from
Closed

Update bundled gRPC to 1.18.0 and nanopb to 0.3.6 #7368

wants to merge 2 commits into from

Conversation

tetromino
Copy link
Contributor

And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file to make importing easier next time.

Fixes #2804.

@tetromino tetromino requested a review from lberki February 6, 2019 21:06
@tetromino tetromino self-assigned this Feb 6, 2019
lberki
lberki approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I'd ask why not the latest nanopb version, but far be it from the to let the perfect be the enemy of the good :)

@tetromino
Copy link
Contributor Author

Nanopb 0.3.6 is what the gRPC upstream currently bundles with their code. I thought we should use the same for consistency.

@kwasimensah
Copy link

A couple of non-blocking questions about how these deps are currently set up

  1. How are there not ODR issues with Bazel and GRPC using possibly different versions of protobuf?

  2. Isn't there also a code bloat/longer build times from having two different versions of it linked in? This is a desktop app so I don't think anyone truly cares but it seems unnecessary.

@tetromino
Add explicit dependency on protoc_lib in cc_grpc_library
a784625 
Required prerequisite for updating bundled gRPC to 1.18.
@tetromino
Update bundled gRPC to 1.18.0 and nanopb to 0.3.6
d0db33b 
And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file (by adopting the same intermediate targets)
to make importing easier next time.

The MSYS2 patch is no longer needed judging by discussion in
https://groups.google.com/forum/#!msg/grpc-io/gd6sIuo6rjQ/eyEFarhABgAJ

Fixes bazelbuild#2804.
@tetromino
Copy link
Contributor Author

@kwasimensah - the bundled third_party/grpc should be using the same third_party/protobuf and third_party/nanopb as the other of c++ code in bazel. At least, that's how the modified third_party/grpc/BUILD file is set up.

@tetromino
Copy link
Contributor Author

Updating to split third_party/ and tools/ changes into separate commits as required by review processes. (And changing the grpc_cpp_plugin label - unfortunately, deviating from gRPC upstream - to make this order of commits possible.)

@tetromino
Copy link
Contributor Author

Commits got applied but in the wrong order due to review process complications; I do apologize for breaking master for 3 commits (458ab03, 6267510, 4c3aeb0).

All should be ok now.

@tetromino tetromino closed this Feb 7, 2019
@tetromino tetromino mentioned this pull request Feb 7, 2019
Closed
@tetromino tetromino deleted the grpc-v1.18.0 branch February 8, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

Assignees

@tetromino tetromino

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update C++ gRPC from 0.13.0
4 participants
@tetromino @kwasimensah @lberki @googlebot