Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C++ gRPC from 0.13.0 #2804

Closed
lberki opened this issue Apr 11, 2017 · 2 comments
Closed

Update C++ gRPC from 0.13.0 #2804

lberki opened this issue Apr 11, 2017 · 2 comments
Assignees
@tetromino
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee)

Comments

@lberki
Copy link
Contributor

lberki commented Apr 11, 2017

0.13.0 is truly ancient and unsupported, so it should be updated to something more recent. It'd also probably help us get rid of the Windows patch. Furthermore, it might also help with the issue whereupon a gRPC thread is still alive when we fork the server and prevents the fork from succeeding.

This probably also requires an update to protobuf.

The Java gRPC library should also be given a closer look.
@buchgr buchgr self-assigned this Apr 11, 2017
@damienmg damienmg added P2 We'll consider working on this in future. (Assignee optional) type: feature request labels Apr 21, 2017
@damienmg damienmg added this to the 0.6 milestone Apr 21, 2017
@buchgr
Copy link
Contributor

buchgr commented May 31, 2017

gRPC Java has been updated to 1.3.0. We considered this more important, as with BEP and Remote Execution gRPC Java talks over real networks while gRPC C++ only talks over loopback.

@buchgr buchgr added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Aug 23, 2017
@buchgr buchgr removed this from the 0.6 milestone Jan 16, 2019
@buchgr buchgr mentioned this issue Feb 5, 2019
Closed
@buchgr buchgr assigned tetromino and unassigned buchgr Feb 5, 2019
@buchgr
Copy link
Contributor

buchgr commented Feb 5, 2019

@tetromino feel free to take this bug!

tetromino added a commit to tetromino/bazel that referenced this issue Feb 6, 2019
@tetromino
Update bundled gRPC to 1.18.0 and nanopb to 0.3.6
63ae146 
And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file to make importing easier next time.

Fixes bazelbuild#2804.
@tetromino tetromino mentioned this issue Feb 6, 2019
Closed
tetromino added a commit to tetromino/bazel that referenced this issue Feb 6, 2019
@tetromino
Update bundled gRPC to 1.18.0 and nanopb to 0.3.6
4652bd1 
And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file (by adopting the same intermediate targets)
to make importing easier next time.

The MSYS2 patch is no longer needed judging by discussion in
https://groups.google.com/forum/#!msg/grpc-io/gd6sIuo6rjQ/eyEFarhABgAJ

Fixes bazelbuild#2804.
tetromino added a commit to tetromino/bazel that referenced this issue Feb 7, 2019
@tetromino
Update bundled gRPC to 1.18.0 and nanopb to 0.3.6
d0db33b 
And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file (by adopting the same intermediate targets)
to make importing easier next time.

The MSYS2 patch is no longer needed judging by discussion in
https://groups.google.com/forum/#!msg/grpc-io/gd6sIuo6rjQ/eyEFarhABgAJ

Fixes bazelbuild#2804.
@tetromino tetromino mentioned this issue Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetromino tetromino

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update bundled gRPC to 1.18.0 and nanopb to 0.3.6 tetromino/bazel
4 participants
@tetromino @buchgr @lberki @damienmg