Replace use of &&& with flatMap() #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kastiglione awesome - thanks for fixing this! I'm testing it out a few times this morning and will merge shortly 👍 |
jerrymarino
approved these changes
Sep 20, 2018
| result, element in | ||
| return result &&& element | ||
| }) | ||
| return result.flatMap { _ in element } |
There was a problem hiding this comment.
Ok interesting - so Result has it's own flatMap that will effectively achieve the same result - this LGTM 👍
There was a problem hiding this comment.
Yeah, and Result's flatMap propagates instances of failure. The result of this reduce + flatMap is a Result that is success if all results were successes, or the first failure found. Based on the caller of this function, this seems like the best implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to build XCHammer with newer dependencies, the use of the deprecated
&&&operator needs to be replaced. See antitypical/Result#220This
reduce()appears to have not been working, because it wasn't modifying theinoutstate.EDIT: It seems that
flatMap()is the correct operation here, notfanout()as I originally had.