-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated APIs #220
Conversation
/// Returns the result of applying `transform` to `Success`es’ values, or re-wrapping `Failure`’s errors. | ||
/// | ||
/// This is a synonym for `flatMap`. | ||
@available(*, deprecated, renamed: "ResultProtocol.flatMap(self:_:)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mark these as unavailable
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no. The operator definitions must be remained to do that. However, we actually want to remove the operators to close #191.
I suppose we should look into removing |
@mdiep I proposed adding the |
Correct |
@Thomvis @mdiep I think for that purpose Parameterized extensions is needed since import Result
public extension<T, E> AsyncType where Value == Result<T, E> {
public var value: T? { ... }
public var error: E? { ... }
} |
@mdiep @Thomvis Do you have further concerns? I'd like to have Result 4.0 with these changes for the forthcoming ReactiveSwift 2.0. |
The protocol can be reduced to return the concrete type like |
Closes #191.