Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply force_swift_local_debug_options transition. #133

Merged
merged 5 commits into from
Oct 7, 2020
Merged

Do not apply force_swift_local_debug_options transition. #133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f7aaec
Do not apply force_swift_local_debug_options transition. When bazel s…
amberdixon Oct 6, 2020
b2ec213
Add documentation
amberdixon Oct 6, 2020
2ffd9ae
Update README.md
amberdixon Oct 7, 2020
3dd5a4e
Address PR feedback and build fixes
amberdixon Oct 7, 2020
ced10b8
Always refer to reponame in command line build setting
amberdixon Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,7 @@ ios_application(
See the [tests](https://github.com/bazel-ios/rules_ios/tree/master/tests)
directory for sample applications.

## Special note about debugging
## Special notes about debugging xcode projects
Note that when generating xcodeprojects, it is necessary to supply the `--//rules:local_debug_options_enabled` so that debugging of swift files will work.
amberdixon marked this conversation as resolved.
Show resolved Hide resolved

Debugging does not work in sandbox mode, due to issue #108. The workaround for now is to disable sandboxing in the .bazelrc file.
2 changes: 1 addition & 1 deletion rules/xcodeproj.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ def _xcodeproj_impl(ctx):
xcodeproj = rule(
implementation = _xcodeproj_impl,
doc = """\
Generates a Xcode project file (.xcodeproj) with a reasonable set of defaults
Generates a Xcode project file (.xcodeproj) with a reasonable set of defaults. Specify the --//rules:local_debug_options_enabled when generating the project to ensure debugging of swiftmodules works.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include the repository in the flag name

Tags for configuration:
xcodeproj-ignore-as-target: Add this to a rule declaration so that this rule will not generates a scheme for this target
""",
Expand Down